Stop dbus mainloop before destroying tray on exit - #2328
Closed
vynride wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Next time, please mark what is your own words and what is AI, same goes for the code. I'll post up an explanation on your issue in a bit as to why I closed this. EDIT: Removed the harsh wording |
Author
|
Hey @C0rn3j, sorry about that. I just wanted to solve the error since I kept getting it randomly when I closed Tauon. I'll keep your review in mind, sorry again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2327
The dbus/MPRIS thread runs a
GLib.MainLoopthat services the SDL tray's libdbusmenu events. It was a daemon thread that was never stopped, so on exitSDL_Quitfreed the tray objects while that thread could still be dispatching callbacks on them, causing an intermittent segfault.This change:
GLib.MainLoopas an attribute onGnomeso it can be stoppedTauonGLib.idle_add, joins the thread with a 2s timeout (logging a warning if it does not stop), destroys the tray explicitly, and only then callsSDL_Quit