fix(lit-form): initialize api before adding controller#1254
Merged
crutchcorn merged 3 commits intoTanStack:mainfrom Mar 20, 2025
Merged
fix(lit-form): initialize api before adding controller#1254crutchcorn merged 3 commits intoTanStack:mainfrom
crutchcorn merged 3 commits intoTanStack:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit d3edfd2.
☁️ Nx Cloud last updated this comment at |
Member
|
I'm more than happy to merge with these tests passing, but could you do a follow-up PR to add a test showcasing this? Would help us prevent future breakage - thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
- Coverage 88.86% 82.85% -6.01%
==========================================
Files 28 1 -27
Lines 1275 35 -1240
Branches 333 5 -328
==========================================
- Hits 1133 29 -1104
+ Misses 127 5 -122
+ Partials 15 1 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following fix allows for lazily instancing the
TanStackFormController. Before it would crash if the element had already rendered becauseaddControllerwould immediately call thehostConnectedcallback and crash becausethis.#apiwould be undefined.