Skip to content

fix(FieldApi): avoid triggering onChange validator when an untouched field calls handleBlur #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeCarbonator merged 1 commit into from
Jun 12, 2025
Merged

fix(FieldApi): avoid triggering onChange validator when an untouched field calls handleBlur #1578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/form-core/src/FieldApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,6 @@ export class FieldApi<
const prevTouched = this.state.meta.isTouched
if (!prevTouched) {
this.setMeta((prev) => ({ ...prev, isTouched: true }))
this.validate('change')
}
if (!this.state.meta.isBlurred) {
this.setMeta((prev) => ({ ...prev, isBlurred: true }))
Expand Down
21 changes: 21 additions & 0 deletions packages/form-core/tests/FieldApi.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2479,4 +2479,25 @@ describe('field api', () => {

expect(field.getMeta().errorSourceMap.onChange).toEqual('field')
})

it('should not run onChange validation when onBlur is triggered', () => {
const form = new FormApi({
defaultValues: { a: '' },
})
form.mount()

const field = new FieldApi({
form,
name: 'a',
validators: {
onChange: () => 'Change error',
onBlur: () => 'Blur error',
},
})
field.mount()

field.handleBlur()

expect(field.state.meta.errors).toStrictEqual(['Blur error'])
})
})