Skip to content

Conversation

@SeanCassiere
Copy link
Member

Important

These reproductions need to be corrected to match the expected route tree and the content to be displayed on the screen.

Starting for the reproductions for #2255

@nx-cloud
Copy link

nx-cloud bot commented Sep 4, 2024

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 3696bee

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 3m 38s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-24 22:37:20 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 4, 2024

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@2262

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@2262

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@2262

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@2262

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@2262

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@2262

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@2262

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@2262

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@2262

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@2262

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@2262

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@2262

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@2262

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@2262

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@2262

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@2262

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@2262

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@2262

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@2262

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@2262

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@2262

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@2262

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@2262

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@2262

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@2262

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@2262

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@2262

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@2262

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@2262

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@2262

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@2262

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@2262

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@2262

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@2262

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@2262

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@2262

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@2262

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@2262

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@2262

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@2262

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@2262

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@2262

commit: 3696bee

@SeanCassiere
Copy link
Member Author

Currently, we've identified 3 scenarios that need resolution.

  1. /about route with an async loader where this is thrown notFound()
<root.NotFoundComponent />
  1. /about route with a non-async loader where this is thrown notFound()
<root.Component>
  <@tanstack/react-router->DefaultGlobalNotFound />
</root.Component>
  1. /route-that-does-not-exist
<root.Component>
  <root.NotFoundComponent />
</root.Component>

2 definitely shouldn't be happening since it should be traversing up the route-tree to select the notFoundComponent.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test-2255

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants