fix(start): discard stream controller errors when closed #3161

phryneas · 2025-01-14T10:57:49Z

Stream Controller: try enqueue/close without throwing error

Both controller.enqueue and controller.close throw an error if the stream has already been closed.

This could be the case because the reading side just doesn't have interest in more incoming values and has closed the stream on the reading side.

Up until now, this would cause an error to be thrown on the console once more chunks or a close request were streamed in.

This wraps .close and .enqueue in a try..catch block and disregards the result.

Reading the standard I don't see any possible other reasons for an error to be thrown, so this should be fine.

packages/start/src/client/Meta.tsx

nx-cloud · 2025-01-15T05:38:00Z

View your CI Pipeline Execution ↗ for commit 7bb69a8.

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	3m 21s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	21s	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-20 18:49:45 UTC

pkg-pr-new · 2025-01-15T05:40:24Z

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3161

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3161

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3161

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3161

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3161

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3161

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3161

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3161

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3161

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3161

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3161

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3161

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3161

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3161

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3161

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3161

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3161

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3161

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3161

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3161

commit: 7bb69a8

phryneas · 2025-01-20T10:14:32Z

packages/start/src/client/tsrScript.ts

+                controller = {
+                  enqueue: (chunk: unknown) => { try { c.enqueue(chunk); } catch {} },
+                  close: () => { try { c.close(); } catch {} },
+                }


Doing this here seems to be the place that is the most defensive - anywhere "further out", it could swallow errors e.g. if controller is still undefined etc.

phryneas · 2025-01-20T10:15:05Z

Force-pushed to reflect the latest change with tsrScript.ts

* add `(TeeTo|ReadFrom)ReadableStreamLink` links * add `skipDataTransport` function * also export type `ReadableStreamLinkEvent` * forgot file * implement multipart streaming * cleanup * WIP * handle re-consumption of readFromReadableStreamKey * close on unsubscribe, catch errors * tryClose, test adjustments * adjust errorlink type * streamline bundling * fix jest integration test * PreloadQuery: add `@defer` example * add detail, suspense-transition-bug * work around bug for now * exports * add exported types * initialize basic react-router project * clean up and `yarn react-router reveal` * add raw experiment * move eslint config into shared position * Fix bundling configuration so parts of the `graphql` package don't end (#388) * Release version 0.11.6@latest to npm * Update peer deps for React 19 compatibility (#399) * update devDependencies to React 19, adjust tests and examples (#400) * Release version 0.11.7@latest to npm * add example * update react-router * working * patch PR in * last adjustments * fix up test for new deps * clean up template fluff * move `IncrementalSchemaLink` and others to `shared` * use `@defer` in the example * update turbo-stream patch * update example to React 19 * adjust `prepublishOnly` * add to pkg-pr-new-publish * add empty unit test * increase delay * streamline integration test build * needs more time in CI * exclude shared * copy react-router package to tanstack-start folder * package init * init tanstack start project * current progress * fix duplicate `@apollo/client` dependency * make things work * adjustments * generalize apiRoute * api, use schemalink on server * update tanstack start * add TSR devtools * workaround for TanStack/router#3117 * trigger CI * update patchfiles * add new properties * changeset * trigger CI * fix build warning * port over vercel template from https://github.com/remix-run/react-router-templates/tree/main/vercel * adjust folder structure * more vercel adjustments * use `promiscade` instead of a patched `turbo-stream` package * update promiscade * add promiscade-related comment * lockfile * workarounds for promiscade * move `graphql` dependency into monorepo to prevent type mismatches * adjust comments * these types are correct now * update lockfile * rename route * add `useSuspenseQuery` demo, too * fix import * simplify client-side * remove log * remove unneccessary type assertion * slight changes, README * fix up important block * fix typo, reorder * fixup shape test * add bundleInfo, adjust tests * adjust tests * adjust for old node * add globalThis.window in test * bump promiscade * update tanstack start, remove workaround for fixed bug * update package.json * add TanStack/router#3161 * lockfile * update correct react types * eliminate context reliance this makes it easier to use `yalc` * sync updates from TanStack/router#2698 * lockfiles * script * fighting with duplicate dependencies * unify react types version * remove unused path * more config file mentions * TSR 6d6780b255c458e9776f15c134d93fab0aeafa80 * pass `request` to `makeClient` in entry.server.tsx * delete file after merge * lockfile * Update packages/tanstack-start/README.md Co-authored-by: Jerel Miller <[email protected]> --------- Co-authored-by: phryneas <[email protected]> Co-authored-by: Nick Muller <[email protected]> Co-authored-by: Jerel Miller <[email protected]>

phryneas commented Jan 14, 2025

View reviewed changes

packages/start/src/client/Meta.tsx Outdated Show resolved Hide resolved

phryneas added a commit to apollographql/apollo-client-integrations that referenced this pull request Jan 14, 2025

add TanStack/router#3161

15565bc

SeanCassiere requested a review from tannerlinsley January 15, 2025 05:37

SeanCassiere changed the title ~~Stream Controller: try enqueue/close without throwing error~~ fix(start): discard steam controller errors when closed Jan 15, 2025

fix(start): discard steam controller errors when closed

c482172

phryneas force-pushed the pr/try-controller branch from 92b9a63 to c482172 Compare January 20, 2025 10:14

phryneas commented Jan 20, 2025

View reviewed changes

phryneas mentioned this pull request Jan 20, 2025

TanStack Start integration apollographql/apollo-client-integrations#412

Merged

schiller-manuel changed the title ~~fix(start): discard steam controller errors when closed~~ fix(start): discard stream controller errors when closed Jan 20, 2025

ci: apply automated fixes

7bb69a8

schiller-manuel merged commit 76fd97e into TanStack:main Jan 21, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(start): discard stream controller errors when closed #3161

fix(start): discard stream controller errors when closed #3161

Uh oh!

phryneas commented Jan 14, 2025 •

edited by SeanCassiere

Loading

Uh oh!

Uh oh!

nx-cloud bot commented Jan 15, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 15, 2025 •

edited

Loading

Uh oh!

phryneas Jan 20, 2025

Uh oh!

phryneas commented Jan 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(start): discard stream controller errors when closed #3161

fix(start): discard stream controller errors when closed #3161

Uh oh!

Conversation

phryneas commented Jan 14, 2025 • edited by SeanCassiere Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stream Controller: try enqueue/close without throwing error

Uh oh!

Uh oh!

nx-cloud bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phryneas Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

phryneas commented Jan 20, 2025

Uh oh!

Uh oh!

Uh oh!

phryneas commented Jan 14, 2025 •

edited by SeanCassiere

Loading

nx-cloud bot commented Jan 15, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 15, 2025 •

edited

Loading