fix(start): discard steam controller errors when closed

[phryneas]

Stream Controller: try enqueue/close without throwing error

Both controller.enqueue and controller.close throw an error if the stream has already been closed.

This could be the case because the reading side just doesn't have interest in more incoming values and has closed the stream on the reading side.

Up until now, this would cause an error to be thrown on the console once more chunks or a close request were streamed in.

This wraps .close and .enqueue in a try..catch block and disregards the result.

Reading the standard I don't see any possible other reasons for an error to be thrown, so this should be fine.

[phryneas]

Doing this here seems to be the place that is the most defensive - anywhere "further out", it could swallow errors e.g. if controller is still undefined etc.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 92b9a63.

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	3m 56s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	1m 18s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-01-15 05:42:35 UTC

[pkg-pr-new]

Open in Stackblitz

More templates

• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-file-based-codesplitting
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsc
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-example-large
• tanstack-start-example-supabase-basic
• tanstack-start-example-trellaux
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3161

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3161

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3161

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3161

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3161

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3161

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3161

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3161

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3161

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3161

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3161

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3161

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3161

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3161

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3161

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3161

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3161

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3161

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3161

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3161

commit: 92b9a63