Skip to content

fix: move solid-js to prod dep on devtools-core #5571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −7
Open

fix: move solid-js to prod dep on devtools-core #5571

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9273ae
chore: move solid-js to prod dep on devtools-core
beaussan Oct 21, 2025
a204c68
Merge branch 'main' into devtools-remove-solid-peer-dep
beaussan Oct 22, 2025
960cfe1
also not bundle solidjs
beaussan Oct 22, 2025
559a559
also remove it from dev deps
beaussan Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/router-devtools-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
"dependencies": {
"clsx": "^2.1.1",
"goober": "^2.1.16",
"vite": "^7.1.7"
"vite": "^7.1.7",
"solid-js": "^1.9.5"
},
"devDependencies": {
"solid-js": "^1.9.5",
Expand All @@ -73,7 +74,6 @@
"peerDependencies": {
"@tanstack/router-core": "workspace:^",
"csstype": "^3.0.10",
"solid-js": ">=1.9.5",
"tiny-invariant": "^1.3.3"
},
"peerDependenciesMeta": {
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading