-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: enable async serverFn validation #5583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
canac
wants to merge
9
commits into
TanStack:main
Choose a base branch
from
canac:async-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+322
−9
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
87fae60
feat: enable async serverFn validation
canac 568328d
Add E2E tests
canac 7c122d2
Add type test
canac bb3be13
Remove need for zod
canac a7226b1
Remove useless await
canac 7892b6b
Combine interfaces
canac 38af395
Simplify validators
canac 22cc026
Add type tests for additional validator formats
canac feb392e
Move Awaited to server-function specific types
canac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
e2e/react-start/server-functions/src/routes/async-validation.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import { createFileRoute } from '@tanstack/react-router' | ||
| import { createServerFn } from '@tanstack/react-start' | ||
| import React from 'react' | ||
| import { z } from 'zod' | ||
|
|
||
| export const Route = createFileRoute('/async-validation')({ | ||
| component: RouteComponent, | ||
| }) | ||
|
|
||
| const asyncValidationSchema = z | ||
| .string() | ||
| .refine((data) => Promise.resolve(data !== 'invalid')) | ||
|
|
||
| const asyncValidationServerFn = createServerFn() | ||
| .inputValidator(asyncValidationSchema) | ||
| .handler(({ data }) => data) | ||
|
|
||
| function RouteComponent() { | ||
| const [errorMessage, setErrorMessage] = React.useState<string | undefined>( | ||
| undefined, | ||
| ) | ||
| const [result, setResult] = React.useState<string | undefined>(undefined) | ||
|
|
||
| const callServerFn = async (value: string) => { | ||
| setErrorMessage(undefined) | ||
| setResult(undefined) | ||
|
|
||
| try { | ||
| const serverFnResult = await asyncValidationServerFn({ data: value }) | ||
| setResult(serverFnResult) | ||
| } catch (error) { | ||
| setErrorMessage(error instanceof Error ? error.message : 'unknown') | ||
| } | ||
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <button | ||
| data-testid="run-with-valid-btn" | ||
| onClick={() => { | ||
| callServerFn('valid') | ||
| }} | ||
| > | ||
| call server function with valid value | ||
| </button> | ||
| <br /> | ||
| <button | ||
| data-testid="run-with-invalid-btn" | ||
| onClick={() => { | ||
| callServerFn('invalid') | ||
| }} | ||
| > | ||
| call server function with invalid value | ||
| </button> | ||
| <div className="p-2"> | ||
| result: <p data-testid="result">{result ?? '$undefined'}</p> | ||
| </div> | ||
| <div className="p-2"> | ||
| message:{' '} | ||
| <p data-testid="errorMessage">{errorMessage ?? '$undefined'}</p> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.