Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/autofix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
if: ${{ github.event_name == 'push' || !github.event.pull_request.draft }}
steps:
- name: Checkout
uses: actions/checkout@v4.2.2
uses: actions/checkout@v4.3.0
- name: Setup Tools
uses: tanstack/config/.github/setup@main
- name: Fix formatting
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4.2.2
uses: actions/checkout@v4.3.0
with:
fetch-depth: 0
- name: Start Nx Agents
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ jobs:
TSR_TMP_DIR: ./tmp
steps:
- name: Checkout
uses: actions/checkout@v4.2.2
uses: actions/checkout@v4.3.0
with:
fetch-depth: 0
- name: Start Nx Agents
run: npx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yaml"
- name: Setup Tools
uses: tanstack/config/.github/setup@main
- name: Get base and head commits for `nx affected`
uses: nrwl/nx-set-shas@v4.1.2
uses: nrwl/nx-set-shas@v4.3.3
with:
main-branch-name: main
- name: Run Checks
Expand All @@ -43,7 +43,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4.2.2
uses: actions/checkout@v4.3.0
with:
fetch-depth: 0
- name: Setup Tools
Expand Down
4 changes: 2 additions & 2 deletions e2e/react-router/basepath-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
"react-dom": "^19.0.0"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
6 changes: 3 additions & 3 deletions e2e/react-router/basic-esbuild-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"zod": "^3.24.2"
"zod": "^3.25.76"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"esbuild": "^0.25.0"
"esbuild": "^0.25.11"
}
}
12 changes: 6 additions & 6 deletions e2e/react-router/basic-file-based-code-splitting/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@
"test:e2e": "rm -rf port*.txt; pnpm run test:e2e:verbose-routes:true && pnpm run test:e2e:verbose-routes:false"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"tailwindcss": "^4.1.15",
"zod": "^3.24.2"
"tailwindcss": "^4.1.16",
"zod": "^3.25.76"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
12 changes: 6 additions & 6 deletions e2e/react-router/basic-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,24 @@
"test:e2e:nonnested": "rm -rf port*.txt; MODE=nonnested playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"@tanstack/zod-adapter": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"zod": "^3.24.2"
"tailwindcss": "^4.1.16",
"zod": "^3.25.76"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"combinate": "^1.1.11",
"vite": "^7.1.7"
}
Expand Down
16 changes: 8 additions & 8 deletions e2e/react-router/basic-react-query-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,25 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tanstack/react-query": "^5.90.0",
"@tanstack/react-query-devtools": "^5.90.0",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-query": "^5.90.5",
"@tanstack/react-query-devtools": "^5.90.2",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"zod": "^3.24.2"
"tailwindcss": "^4.1.16",
"zod": "^3.25.76"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
14 changes: 7 additions & 7 deletions e2e/react-router/basic-react-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,23 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tanstack/react-query": "^5.90.0",
"@tanstack/react-query-devtools": "^5.90.0",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-query": "^5.90.5",
"@tanstack/react-query-devtools": "^5.90.2",
"@tanstack/react-router": "workspace:^",
"@tanstack/router-devtools": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.16"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
12 changes: 6 additions & 6 deletions e2e/react-router/basic-scroll-restoration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/react-virtual": "^3.13.0",
"postcss": "^8.5.1",
"@tanstack/react-virtual": "^3.13.12",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.16"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
12 changes: 6 additions & 6 deletions e2e/react-router/basic-virtual-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,24 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"@tanstack/virtual-file-routes": "workspace:^",
Comment on lines 15 to 18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use workspace:* instead of workspace:^ for internal dependencies.

Per coding guidelines, internal workspace dependencies should use workspace:* protocol, not workspace:^. Update lines 15–18 accordingly.

Apply this diff:

 "dependencies": {
-  "@tanstack/react-router": "workspace:^",
-  "@tanstack/react-router-devtools": "workspace:^",
-  "@tanstack/router-plugin": "workspace:^",
-  "@tanstack/virtual-file-routes": "workspace:^",
+  "@tanstack/react-router": "workspace:*",
+  "@tanstack/react-router-devtools": "workspace:*",
+  "@tanstack/router-plugin": "workspace:*",
+  "@tanstack/virtual-file-routes": "workspace:*",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"@tanstack/virtual-file-routes": "workspace:^",
"@tanstack/react-router": "workspace:*",
"@tanstack/react-router-devtools": "workspace:*",
"@tanstack/router-plugin": "workspace:*",
"@tanstack/virtual-file-routes": "workspace:*",
🤖 Prompt for AI Agents
In e2e/react-router/basic-virtual-file-based/package.json around lines 15 to 18,
the internal workspace dependencies use the incorrect protocol "workspace:^";
update each of those dependency entries to use "workspace:*" instead so the
package.json declares internal workspace packages with the required workspace
protocol.

"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"zod": "^3.24.2"
"tailwindcss": "^4.1.16",
"zod": "^3.25.76"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use workspace:* instead of workspace:^ for internal dependencies.

Line 28 also uses workspace:^ for @tanstack/router-e2e-utils. Update to workspace:* for consistency with coding guidelines.

Apply this diff:

 "devDependencies": {
-  "@tanstack/router-e2e-utils": "workspace:^",
+  "@tanstack/router-e2e-utils": "workspace:*",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@tanstack/router-e2e-utils": "workspace:^",
"@tanstack/router-e2e-utils": "workspace:*",
🤖 Prompt for AI Agents
In e2e/react-router/basic-virtual-file-based/package.json around line 28, the
dependency version for @tanstack/router-e2e-utils uses workspace:^; change it to
workspace:* to follow internal dependency guidelines—open the file, locate the
"@tanstack/router-e2e-utils": "workspace:^" entry and replace the version
specifier with "workspace:*", save the file and run a quick install to ensure no
lockfile conflicts.

"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,24 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"@tanstack/virtual-file-routes": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"zod": "^3.24.2"
"tailwindcss": "^4.1.16",
"zod": "^3.25.76"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
10 changes: 5 additions & 5 deletions e2e/react-router/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.16"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
10 changes: 5 additions & 5 deletions e2e/react-router/generator-cli-only/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/router-cli": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.16"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
10 changes: 5 additions & 5 deletions e2e/react-router/js-only-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
"@tailwindcss/postcss": "^4.1.15",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"postcss": "^8.5.1",
"postcss": "^8.5.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.16"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@playwright/test": "^1.56.1",
"@tanstack/router-e2e-utils": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^7.1.7"
}
}
12 changes: 6 additions & 6 deletions e2e/react-router/rspack-basic-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
"redaxios": "^0.5.1"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
"@rsbuild/core": "^1.2.4",
"@rsbuild/plugin-react": "^1.1.0",
"@tailwindcss/postcss": "^4.1.15",
"@playwright/test": "^1.56.1",
"@rsbuild/core": "^1.5.17",
"@rsbuild/plugin-react": "^1.4.1",
"@tailwindcss/postcss": "^4.1.16",
"@tanstack/router-e2e-utils": "workspace:^",
"@tanstack/router-plugin": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.15",
"postcss": "^8.5.6",
"tailwindcss": "^4.1.16",
"typescript": "^5.7.2"
}
}
Loading
Loading