Skip to content

fix(router-core): process route tree should avoid float arithmetics #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(router-core): process route tree should avoid float arithmetics #5688

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7ff589
fix(router-core): process route tree should avoid float arithmetics
Sheraff Oct 29, 2025
907712d
try without Object.values
Sheraff Oct 29, 2025
0583040
try pre-sorting routes
Sheraff Oct 29, 2025
b07066c
unit test
Sheraff Oct 29, 2025
680f08b
ci: apply automated fixes
autofix-ci[bot] Oct 29, 2025
57302c1
pouet
Sheraff Oct 29, 2025
bb7543e
Update packages/router-core/tests/processRouteTree.test.ts
Sheraff Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/router-core/src/process-route-tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ import {
import type { Segment } from './path'
import type { RouteLike } from './route'

const SLASH_SCORE = 0.75
const STATIC_SEGMENT_SCORE = 1
const REQUIRED_PARAM_BASE_SCORE = 0.5
const OPTIONAL_PARAM_BASE_SCORE = 0.4
const WILDCARD_PARAM_BASE_SCORE = 0.25
const STATIC_AFTER_DYNAMIC_BONUS_SCORE = 0.2
const BOTH_PRESENCE_BASE_SCORE = 0.05
const PREFIX_PRESENCE_BASE_SCORE = 0.02
const SUFFIX_PRESENCE_BASE_SCORE = 0.01
const PREFIX_LENGTH_SCORE_MULTIPLIER = 0.0002
const SUFFIX_LENGTH_SCORE_MULTIPLIER = 0.0001
const SLASH_SCORE = 7500
const STATIC_SEGMENT_SCORE = 10000
const REQUIRED_PARAM_BASE_SCORE = 5000
const OPTIONAL_PARAM_BASE_SCORE = 4000
const WILDCARD_PARAM_BASE_SCORE = 2500
const STATIC_AFTER_DYNAMIC_BONUS_SCORE = 2000
const BOTH_PRESENCE_BASE_SCORE = 500
const PREFIX_PRESENCE_BASE_SCORE = 200
const SUFFIX_PRESENCE_BASE_SCORE = 100
const PREFIX_LENGTH_SCORE_MULTIPLIER = 2
const SUFFIX_LENGTH_SCORE_MULTIPLIER = 1

function handleParam(segment: Segment, baseScore: number) {
if (segment.prefixSegment && segment.suffixSegment) {
Expand Down
Loading