refactor(router-core): Process routeTree into segment tree instead of flatRoutes [WIP] #5722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:eslint,test:unit,tes... |
❌ Failed | 53s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
❌ Failed | 4s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-02 16:48:33 UTC
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Sheraff
commented
Nov 3, 2025
| + (b.prefix ? b.prefix.length * 2 : 0) | ||
| // suffix counts single | ||
| + (b.suffix ? b.suffix.length : 0) | ||
| return bScore - aScore |
There was a problem hiding this comment.
fallback to alphabetical if same score
Sheraff
commented
Nov 3, 2025
Comment on lines
+599
to
+601
| if (!wildcardMatch || (wildcardMatch.index < index)) { | ||
| wildcardMatch = { node: segment, index, skipped, depth } | ||
| } |
There was a problem hiding this comment.
score should be on DynamicNode, used in sort above, and in here if both indices are equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untested, DO NOT MERGE
design exploration of a rewrite of
processRouteTreeto yield a trie-like tree of segments. This should replacepackages/router-core/src/process-route-tree.tspackages/router-core/src/path.tsgoals:
non-goals:
to-do:
/)consequences:
resolvePath) should be rewritten to avoid having 2 competing implementations ofparsePathname