Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade searchbox / add suggestions / fix theme #312

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: upgrade searchbox / add suggestions / fix theme #312

merged 1 commit into from
Dec 20, 2024

Conversation

rjborba
Copy link
Contributor

@rjborba rjborba commented Nov 29, 2024

This PR:

  • Upgrades Orama components version. It fixes several styles issue and others.
  • Uses dynamic theme so SearchBox colors matches the selected theme.
  • Adds chat messages suggestions
image image

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2024 •
edited
Loading

✅ Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit f5d0678
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/67657d091a7115000807fc23
😎 Deploy Preview https://deploy-preview-312--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 49 (🔴 down 27 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 84 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024

@rjborba is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@rjborba rjborba force-pushed the upgradeOramaSearchbox branch from 7b4dec2 to ed994d6 Compare December 3, 2024 13:39
@rjborba rjborba requested a review from tannerlinsley December 9, 2024 21:28
@tannerlinsley
Copy link
Collaborator

Yep! Just resolve conflicts and we’re good

@rjborba rjborba force-pushed the upgradeOramaSearchbox branch from 4fa116a to 04ea372 Compare December 11, 2024 00:41
@rjborba
Copy link
Contributor Author

rjborba commented Dec 11, 2024

Yep! Just resolve conflicts and we’re good

@tannerlinsley We should good to go now, then. Thanks! :)

@rjborba rjborba force-pushed the upgradeOramaSearchbox branch from 04ea372 to f5d0678 Compare December 20, 2024 14:19
@rjborba
Copy link
Contributor Author

rjborba commented Dec 20, 2024

@tannerlinsley Hi! Conflicts are fixed. Can we move on with this?

@tannerlinsley tannerlinsley merged commit c90105b into TanStack:main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannerlinsley tannerlinsley Awaiting requested review from tannerlinsley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjborba @tannerlinsley