Adding windows support for News Reader #1
Conversation
|
|
||
| if __name__ == '__main__': | ||
|
|
||
| exit_flag = 0 |
There was a problem hiding this comment.
No point in adding flag, just append code in one if-else
| @@ -0,0 +1,47 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
it would be great if you can have the same name "NewsReader" for windows version as well.
There was a problem hiding this comment.
Cool, changing whats_up.py to NewsReader.py
| ## Function to store key to file | ||
| def add_key(): | ||
|
|
||
| key = input('Enter News-API key: ') |
There was a problem hiding this comment.
Give them the link of page where they can generate the key.
| print(article["url"]) | ||
| print(article["description"]) | ||
|
|
||
|
|
There was a problem hiding this comment.
Good work here, but i feel we need to identify functions that are same for both versions, instead of repeating the same code.
There was a problem hiding this comment.
Correct. Need to have one single file to be called from windows or mac. Need to change the folder structure.
windows/commands.bat
Outdated
| @@ -0,0 +1,2 @@ | |||
| chcp 65001 | |||
| python3 newsUpdate.py 9f055cb1404449f79aca035f832b32f9 No newline at end of file | |||
There was a problem hiding this comment.
hahaha now world knows your key
2 participants
Adding support for windows