Sync with upstream changes #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow changing the base class for `EventJob` This is necessary if you want to change the queue for `EventJob`. Otherwise #192 (comment) doesn't work. * remove this entirely * changelog * oops
* Include `Noticed::Translation` in `Noticed::Ephemeral` Ooops, I should have included this in #484, sorry. * Update ephemeral.rb
* Allow use of evaluated recipients in ephemeral notifiers * lint
) * Add details about how to vary queue priority * Update README.md --------- Co-authored-by: Chris Oliver <[email protected]>
…apnotic connection (#503)
* Corrected typo --------- Co-authored-by: Shane Reddy <[email protected]>
I see the config blocks don't receive params anymore
--------- Co-authored-by: Chris Oliver <[email protected]>
v2 has been out long enough and it's easy enough to find UPGRADE.md
* Add Action Push Native delivery method * Only set app deprecator for supported rails versions * Add silent and fix notification instantiation * Refactor config to match factory methods * Update notes * Fix deliver later for APN * Remove app deprecator * Revert deprecator version
* Don't eager load notification channel with zeitwerk Fixes #558 * Enable eager loading in CI
fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
22 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Pull in latest changes from excid3/noticed"
Need
464545c(#1) for serialization and bumping our rails edge commit