Optimize Dockerfile and build process #4039
Conversation
wilmardo
changed the title
Signed-off-by: wilmardo <[email protected]>
Signed-off-by: wilmardo <[email protected]>
…minimum Signed-off-by: wilmardo <[email protected]>
Signed-off-by: wilmardo <[email protected]>
|
thanks for this and the other PR's |
|
No worries, let me know if there are any questions also @theProf feel free to shoot some comments. I decided on less stages to keep the Dockerfile more simple and readable |
| COPY --link requirements.txt ./ | ||
|
|
||
| RUN <<EOF | ||
| # remove Development dependencies from requirements.txt | ||
| sed -i '/# Development/,$d' requirements.txt | ||
| apk add --no-cache --virtual .build-deps \ | ||
| build-base \ | ||
| cargo \ | ||
| curl \ | ||
| g++ \ | ||
| gcc \ | ||
| jpeg-dev \ | ||
| libffi-dev \ | ||
| libwebp-dev \ | ||
| musl-dev \ | ||
| postgresql-dev \ | ||
| python3-dev \ | ||
| openldap-dev \ | ||
| openssl-dev \ | ||
| xmlsec \ | ||
| xmlsec-dev \ | ||
| rust \ | ||
| zlib-dev | ||
| python -m venv venv | ||
| venv/bin/python -m pip install --upgrade pip | ||
| venv/bin/pip debug -v | ||
| venv/bin/pip install wheel==0.45.1 | ||
| venv/bin/pip install setuptools_rust==1.10.2 | ||
| venv/bin/pip install -r requirements.txt --no-cache-dir | ||
| apk --purge del .build-deps | ||
| EOF |
There was a problem hiding this comment.
I suggest moving building the venv to a separate stage. This way we would have one stage for the frontend and its build dependencies, one stage for the backend and its build dependencies, and one final image with runtime dependencies.
|
|
||
| RUN <<EOF | ||
| # remove Development dependencies from requirements.txt | ||
| sed -i '/# Development/,$d' requirements.txt |
There was a problem hiding this comment.
Rather out of scope for this PR, but I think the Python dev dependencies should be moved to another file to cleanly separate them, for example in requirements_dev.txt.
4 participants
Somewhat of a simpler implementation of #3919
@theProf I cherry-picked some of your work to not discard your work :)
docker buildends up as a working image instead of missing the compiled frontend.gitdirectory can be omitted from the container