Refactor v2 - #31
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Add focused unit tests across utils, highway, display, and job packages covering parsing, state persistence, progress accounting, and stream handling. Fix HTTP downloader progress accounting so the percentage no longer bounces or exceeds 100% during chunk retries by reconciling chunk.Downloaded with on-disk size and emitting signed deltas. Co-authored-by: Cursor <cursoragent@cursor.com>
This adds a comprehensive plan for integrating yt-dlp into danzo as an internal job using `--progress-template` to output newline-delimited JSON to stdout. Evidence from various test cases including multiphase downloading is included within the markdown file. Co-authored-by: Tanq16 <37408906+Tanq16@users.noreply.github.com>
This commit updates `ytdlp-integration.md` to include raw test execution evidence from downloading via a Vimeo URL alongside a full, runnable example of how to write the Go integration code. The Go sample invokes `exec.Command`, uses the `yt-dlp` `--progress-template` flag, and successfully parses the output using a scanner and `encoding/json`. Co-authored-by: Tanq16 <37408906+Tanq16@users.noreply.github.com>
This commit adds analysis and concrete Go code examples to `ytdlp-integration.md` demonstrating how to handle sequential downloading steps (like downloading video first, then audio) and parsing `[Merger]` text logs to properly emit substatus progress updates within the `highway` architecture. Co-authored-by: Tanq16 <37408906+Tanq16@users.noreply.github.com>
Implemented a new job package for yt-dlp that executes the binary using its JSON progress template for seamless highway architecture integration. Added `ytdlp` as a supported command and registered it in the CLI. Co-authored-by: Tanq16 <37408906+Tanq16@users.noreply.github.com>
Harden yt-dlp wrapper with stderr capture, single failure reporting, output-path collision handling, and focused unit tests. Document ytdlp in README, remove the planning doc, and add manual integration scripts for ghr (terraform) and a 500 MB HTTP download to USB test storage. Co-authored-by: Cursor <cursoragent@cursor.com>
Use tanq16/anbu for unauthenticated ghr (GitHub release assets) and thinkbroadband 512MB for http. Document why terraform and link.testfile.org are unsuitable for CLI integration runs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.