spiped: fix 'goto err' labels#428
Open
gperciva wants to merge 1 commit into
Open
Conversation
Member
Author
|
Looking through the history, the first sketch of this commit in #353 required all the The bug reporter notes that dereferencing a NULL pointer is a crash. I'm guessing that you would classify this as a "harmless" bug. |
This should have been part of:
2022-08-03 spipe & spiped: add -b to bind outgoing address
c6cea35
When we added the "resolve the bind address" part, we (correctly)
incremented the subsequent errX numbers by 1 -- except for setuidgid()
and dispatch_accept(), which we incremented by 2 (!).
Looking through the history, the first sketch of this commit required
all the errX numbers to increment by 2. When we added
sock_resolve_one(), that meant this commit only required main.c's errX
numbers to increment by 1, but evidently we missed two instances of that
change.
Reported by: ChronoNova
Bug bounty: $10 ("harmless")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.