fix(router): correct primary vendor fallback behavior

[kaushik-yadav]

Summary

Fixes issue #289 where the vendor router continued into fallback
vendors even after all primary vendors were attempted.

What was happening

• With configs like "reddit,alpha_vantage", the router tried ALL vendors.
• It didn't stop after primary vendors were done.
• This caused unnecessary vendor calls and inconsistent behavior.

Fix

• Added logic to stop routing after all primary vendors have been attempted.
• Fallback vendors now only run if a primary vendor fails.

Result

Primary vendors execute in order and fallback is used only when needed.

[gemini-code-assist]

Summary of Changes

Hello @kaushik-yadav, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the vendor routing mechanism where the system would continue to attempt fallback vendors even after all designated primary vendors had been tried. The changes refactor the routing logic to ensure that fallback vendors are only invoked if all primary vendors fail, thereby optimizing vendor calls and ensuring more predictable and correct behavior.

Highlights

• Corrected Primary Vendor Fallback Behavior: The router previously attempted all vendors (primary and fallback) even after primary vendors were exhausted. This fix ensures that fallback vendors are only engaged if all primary vendors fail, preventing unnecessary calls and inconsistent behavior.
• Improved Vendor Routing Logic: The route_to_vendor function has been refactored to clearly separate the handling of primary and fallback vendors. Primary vendors are now attempted first, and if any succeed, the process stops. Only if all primary vendors fail will the fallback vendors be tried.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the vendor routing logic to correctly handle primary and fallback vendors. The change ensures that fallback vendors are only attempted after all primary vendors have failed, which fixes the described issue. The new implementation is clearer and more correct. I've added a couple of suggestions to further improve the robustness and maintainability of the new logic.

[kaushik-yadav]

Pushed additional changes addressing Gemini Code Assist suggestions.