Skip to content

[CHORE/#243] 변경된 링크를 반영합니다.#244

Merged
SYAAINN merged 1 commit intodevelopfrom
chore/#243-link-update
Mar 31, 2025
Merged

[CHORE/#243] 변경된 링크를 반영합니다.#244
SYAAINN merged 1 commit intodevelopfrom
chore/#243-link-update

Conversation

@SYAAINN
Copy link
Contributor

@SYAAINN SYAAINN commented Mar 31, 2025

📌 ISSUE

Closed #243

📄 Work Description

공지사항 / 개인정보처리방침 / 서비스 이용약관의 변경된 링크들을 반영하였습니다.

✨ PR Point

아직은 딱히 없습니다! 잘 진입 되는것도 확인 하였습니다!

Summary by CodeRabbit

  • Chores
    • Updated the app’s web links for announcements, terms of service, and privacy policy pages. Users accessing these sections will now be directed to new online resources, ensuring they receive the most current information. This change guarantees that you always access accurate and up-to-date details.

@SYAAINN SYAAINN added ❤️‍🩹 CHORE 작은 수정(타입변수, 패키지구조 변경 등) 🔥 민재 민재 labels Mar 31, 2025
@SYAAINN SYAAINN requested a review from MoonsuKang March 31, 2025 06:39
@SYAAINN SYAAINN self-assigned this Mar 31, 2025
@coderabbitai
Copy link

coderabbitai bot commented Mar 31, 2025

Walkthrough

The changes update the URL constants in the SettingOptionUrls.kt file. The ANNOUNCEMENT_URL, TERMS_OF_SERVICE_URL, and PRIVACY_POLICY_URL constants have been modified to point to new Notion URLs, while the INQUIRIES_SUGGESTIONS_URL remains unchanged. No structural or control flow modifications were made.

Changes

File Change Summary
app/src/.../SettingOptionUrls.kt Updated the values of ANNOUNCEMENT_URL, TERMS_OF_SERVICE_URL, and PRIVACY_POLICY_URL to new Notion URLs; INQUIRIES_SUGGESTIONS_URL remains unchanged.

Poem

In the code garden where URLs bloom,
I hop with joy at their fresh, new room,
Notion paths now gleam in renewed light,
Each constant updated, a sweet delight,
A bunny’s cheer in every line that’s penned.
Hop along, my dear, let the changes extend!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dde8b5e and 189557d.

📒 Files selected for processing (1)
  • app/src/main/java/com/sopt/clody/presentation/ui/setting/screen/SettingOptionUrls.kt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (3)
app/src/main/java/com/sopt/clody/presentation/ui/setting/screen/SettingOptionUrls.kt (3)

4-4: Updated Announcement URL is Correct

The ANNOUNCEMENT_URL constant now points to the new Notion URL ("https://www.notion.so/1c7e3fedb3f48029b36cf9d76c5fb6d6?pvs=21") as per the PR objectives. The format and query parameters appear consistent with the intended update.


6-6: Updated Terms of Service URL is Correct

The TERMS_OF_SERVICE_URL constant has been updated to "https://www.notion.so/1c7e3fedb3f4802c8db1f3056c03973f?pvs=21". This change aligns with the PR objective to reflect the latest URL changes for the Terms of Service.


7-7: Updated Privacy Policy URL is Correct

The PRIVACY_POLICY_URL constant now references the new URL ("https://www.notion.so/1c7e3fedb3f48024a334c8116255b378?pvs=21"). This update is in line with the pull request requirements for the Privacy Policy link update.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@MoonsuKang MoonsuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿
!
아 그리고 갑자기 생각난게 노션 웹뷰 안된다고 우리 그때 뭔가 다른 방법으로 했었던거 같은데

  layoutParams = ViewGroup.LayoutParams(
      ViewGroup.LayoutParams.MATCH_PARENT,
      ViewGroup.LayoutParams.MATCH_PARENT,
  )

요거를 추가하면 된다는 것을 깨달아버렸습니다잉!

@SYAAINN SYAAINN merged commit 515c6ff into develop Mar 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❤️‍🩹 CHORE 작은 수정(타입변수, 패키지구조 변경 등) 🔥 민재 민재

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] 설정 속 웹뷰 화면들의 링크를 변경합니다.

2 participants