[REFACTOR/#249] signing 설정 수정 및 버전 수정#250
Conversation
WalkthroughThe pull request updates the build configuration for the application. In the Changes
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/build.gradle.kts (1)
43-50: Release Signing Configuration Addition
The newsigningConfigsblock correctly sets up the release signing configuration by loading properties fromlocal.properties. Consider adding validation or default handling for these properties to avoid potential build issues if any signing detail is missing. This could help prevent misconfigurations during the CI/CD process.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/build.gradle.kts(3 hunks)
🔇 Additional comments (2)
app/build.gradle.kts (2)
28-29: Version Update Consistency Check
TheversionCodehas been updated to 23 andversionNameto "1.1.0", which aligns with your new release versioning. Please ensure that these values match your intended release and that any related dependencies or documentation are updated accordingly.
66-66: Release Build Signing Assignment
Switching thesigningConfigin thereleasebuild type from the debug configuration to the newly created "release" configuration is appropriate for generating signed AAB files. Ensure that the CI/CD workflow securely manages these keys and that the properties used are correctly populated in your environment.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_ci.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
.github/workflows/android_ci.yml (1)
82-94: Correct Integration of Signing Credentials into local.properties
The updatedGenerate local.propertiesstep correctly appends the signing configuration properties (storeFile,storePassword,keyAlias, andkeyPassword) to thelocal.propertiesfile. This integration supports the new release signing process. Ensure that the corresponding secrets are properly set in the GitHub repository and that these properties are used by your Android build script as expected.
| # keystore 복호화 | ||
| - name: Decode keystore file | ||
| env: | ||
| STORE_FILE_BASE: ${{ secrets.STORE_FILE }} | ||
| run: | | ||
| mkdir -p keystore | ||
| echo "$STORE_FILE" | base64 --decode > keystore/clody_release.jks | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Variable Mismatch in Keystore Decoding Step
The keystore decoding step defines an environment variable STORE_FILE_BASE (line 69) but uses $STORE_FILE (line 72) when decoding the keystore file. This mismatch may result in an empty or incorrect keystore file during the build process. Please update the variable reference to ensure consistency.
- echo "$STORE_FILE" | base64 --decode > keystore/clody_release.jks
+ echo "$STORE_FILE_BASE" | base64 --decode > keystore/clody_release.jks📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # keystore 복호화 | |
| - name: Decode keystore file | |
| env: | |
| STORE_FILE_BASE: ${{ secrets.STORE_FILE }} | |
| run: | | |
| mkdir -p keystore | |
| echo "$STORE_FILE" | base64 --decode > keystore/clody_release.jks | |
| # keystore 복호화 | |
| - name: Decode keystore file | |
| env: | |
| STORE_FILE_BASE: ${{ secrets.STORE_FILE }} | |
| run: | | |
| mkdir -p keystore | |
| echo "$STORE_FILE_BASE" | base64 --decode > keystore/clody_release.jks |
2 participants
📌 ISSUE
closed #249
📄 Work Description
✨ PR Point
REFACTOR/[REFACTOR] signing 설정 수정 및 버전 수정 #249 -> develop -> staging -> release 이 순서로 해서 CI/CD가 다 잘 돌면 플레이스토어에 배포 할게요~
📸 ScreenShot/Video
Summary by CodeRabbit
Our latest release includes a significant version update and build security enhancements to offer users a more stable and reliable app experience.
New Features
Chores