[Feat/#265] 임시저장 API연결을 진행합니다. #271
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package com.sopt.clody.domain.model | ||
|
|
||
| data class CreatedDraftDiaryInfo( | ||
| val createdAt: String, | ||
| ) |
|
Contributor
There was a problem hiding this comment. [p3]
1번만큼 중요한게 2번 기준이라고 개인적으로 생각합니다. 그래서 꼭 필요한 Model인가? 비즈니스적인 성격이 잘 드러나는가? 변경 가능성이 작은가? 등을 항상 고려하려고 하는데 지금처럼 간단한 List 타입 하나만 들어있으며, 쓰임새도 확실한(?) 것 같은 경우에는 그냥 별도의 모델 제작하지 않고 List 가 아닌 List으로 사용하는 것은 어떻게 생각하세요?
Contributor
Author
There was a problem hiding this comment. 도메인 관점에서 "임시 저장된 일기 모음"이라는 개념을 갖고 있다고 생각해서 별도 모델로 분리를 했습니다... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package com.sopt.clody.domain.model | ||
|
|
||
| data class DraftDiaryContents( | ||
| val draftDiaries: List<String>, | ||
| ) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[p3]
createdAt 정보가 쓰이는 곳이 없는 걸로 파악이 되는데, 일단 서버가 이 값을 내려주는 이유도 궁금하고 굳이 Domain Layer에도 만들어야하나? 라는 생각이 듭니다😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저 생성시간을 홈 분기에서 쓰는 걸로 처음에 이해해서 만들어놨었는데 지금 보니 그냥 any?로 처리해도 될거 같네요! 제거 하겠습니다잉