[Feat/#268] 이어쓰기 알림 설정을 유도하는 기능을 구현합니다.#272
Conversation
|
""" WalkthroughThis update introduces a feature to prompt users to enable draft notifications after their first use of the draft functionality. It adds new local data source interfaces and implementations, dependency injection qualifiers, and ViewModel logic to manage the draft usage state and notification prompt. UI components are updated to display a popup and toast for this feature. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WriteDiaryScreen
participant WriteDiaryViewModel
participant DraftRepository
participant FirstDraftLocalDataSource
participant HomeScreen
participant HomeViewModel
participant NotificationRepository
User->>WriteDiaryScreen: Dismiss Exit Dialog
WriteDiaryScreen->>WriteDiaryViewModel: updateDraftUsage()
WriteDiaryViewModel->>DraftRepository: getIsDraftUsed()
DraftRepository->>FirstDraftLocalDataSource: get/set isDraftUsed, isFirstUse
User->>HomeScreen: Navigates to Home
HomeScreen->>HomeViewModel: Check showFirstDraftPopup
HomeViewModel->>DraftRepository: getIsFirstUse()
HomeScreen->>User: Show popup if first use
User->>HomeScreen: Click "Enable Draft Alarm"
HomeScreen->>HomeViewModel: enableDraftAlarm(context)
HomeViewModel->>NotificationRepository: getNotificationInfo, sendDraftAlarmRequest
HomeViewModel->>HomeScreen: Show toast on success
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeScreen.kt (1)
127-180: Consider accessibility improvements for the popup.The popup implementation is functionally correct and provides clear information to users. However, there's a potential accessibility concern:
The "다음에 하기" (Skip for now) text uses a generic
clickablemodifier without proper semantic information.Consider improving accessibility:
Text( text = "다음에 하기", modifier = Modifier - .clickable(onClick = { homeViewModel.updateFirstDraftUse(false) }) + .clickable( + onClick = { homeViewModel.updateFirstDraftUse(false) }, + role = Role.Button + ) + .semantics { contentDescription = "다음에 하기 버튼" } .padding(12.dp), color = ClodyTheme.colors.gray05, style = ClodyTheme.typography.body4Medium, )Also import the necessary semantics:
import androidx.compose.foundation.semantics.Role import androidx.compose.foundation.semantics.contentDescription import androidx.compose.foundation.semantics.semanticsapp/src/main/java/com/sopt/clody/data/local/datasourceimpl/FirstDraftLocalDataSourceImpl.kt (1)
15-17: Consider renamingisFirstUsefor clarity.The property name
isFirstUseis ambiguous. Based on the usage inHomeViewModel, it appears to track whether the user should see the first draft notification prompt. Consider a more descriptive name likeshouldShowFirstDraftPromptorhasSeenDraftPrompt(with inverted logic).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
app/src/main/java/com/sopt/clody/data/datastore/TokenDataStoreImpl.kt(1 hunks)app/src/main/java/com/sopt/clody/data/local/datasource/FirstDraftLocalDataSource.kt(1 hunks)app/src/main/java/com/sopt/clody/data/local/datasourceimpl/FirstDraftLocalDataSourceImpl.kt(1 hunks)app/src/main/java/com/sopt/clody/di/SharedPreferencesModule.kt(2 hunks)app/src/main/java/com/sopt/clody/di/TokenDataStoreModule.kt(2 hunks)app/src/main/java/com/sopt/clody/di/qualifier/Qualifier.kt(1 hunks)app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeScreen.kt(5 hunks)app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt(4 hunks)app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryScreen.kt(1 hunks)app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryViewModel.kt(3 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeScreen.kt (3)
app/src/main/java/com/sopt/clody/presentation/ui/component/popup/ClodyPopupBottomSheet.kt (1)
ClodyPopupBottomSheet(28-77)app/src/main/java/com/sopt/clody/presentation/ui/component/button/ClodyButton.kt (1)
ClodyButton(14-43)app/src/main/java/com/sopt/clody/presentation/ui/component/toast/ClodyToastMessage.kt (1)
ClodyToastMessage(27-66)
app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt (3)
app/src/main/java/com/sopt/clody/presentation/ui/setting/notificationsetting/screen/NotificationSettingViewModel.kt (2)
getNotificationInfo(59-91)getTokenFromPreferences(190-193)app/src/main/java/com/sopt/clody/data/repositoryimpl/NotificationRepositoryImpl.kt (1)
getNotificationInfo(14-17)app/src/main/java/com/sopt/clody/presentation/ui/auth/timereminder/TimeReminderViewModel.kt (1)
getTokenFromPreferences(75-78)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (15)
app/src/main/java/com/sopt/clody/di/SharedPreferencesModule.kt (3)
5-8: Clean dependency injection setup for the first draft feature.The new imports and qualifier usage follow proper DI patterns and maintain clear separation between different SharedPreferences instances.
20-20: Good addition of @TokenPrefs qualifier for consistency.This ensures proper disambiguation between different SharedPreferences instances in the dependency injection graph.
27-37: Well-structured provider methods for first draft functionality.The naming convention and dependency chain from SharedPreferences to FirstDraftLocalDataSource is clear and follows good practices.
app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryScreen.kt (1)
141-145: Excellent integration of draft usage tracking.The placement of
updateDraftUsage()call in the dismiss callback is logical - it properly tracks when users choose to save their work as a draft before exiting.app/src/main/java/com/sopt/clody/data/datastore/TokenDataStoreImpl.kt (1)
4-4: Proper qualifier usage for dependency injection consistency.The addition of
@TokenPrefsqualifier aligns with the refactored dependency injection setup and ensures the correct SharedPreferences instance is injected.Also applies to: 8-8
app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryViewModel.kt (2)
10-10: Clean integration of FirstDraftLocalDataSource dependency.The import and constructor injection follow proper patterns and maintain the ViewModel's dependency management approach.
Also applies to: 26-26
174-179:Details
✅ Verification successful
Verify the logic for isFirstUse flag setting.
The current implementation sets
isFirstUse = trueevery timeisDraftUsedis false. This might not align with the intended behavior ifisFirstUseshould only be set once on the very first draft usage and then remain true.Please verify that this logic correctly implements the first draft detection requirement. Consider whether
isFirstUseshould be set only once or reset for each new draft session.
🏁 Script executed:
#!/bin/bash # Description: Check how isFirstUse is consumed in the codebase to understand intended behavior # Expected: Find usages that show whether isFirstUse should be set once or multiple times echo "Searching for isFirstUse property usage..." rg -A 3 -B 3 "isFirstUse" echo -e "\nSearching for FirstDraftLocalDataSource interface definition..." ast-grep --pattern $'interface FirstDraftLocalDataSource { $$$ }'Length of output: 5282
No action needed on
isFirstUselogicThe flag is only set when
isDraftUsedis false, and sinceisDraftUsedis persisted in SharedPreferences, this happens only once—exactly as intended. The HomeViewModel’supdateFirstDraftUse()call then clearsisFirstUseafter the popup is shown, preventing it from re-triggering.app/src/main/java/com/sopt/clody/di/qualifier/Qualifier.kt (1)
1-12: LGTM! Clean qualifier implementation for dependency injection.The qualifiers are properly implemented following Dagger best practices. Using
BINARYretention is appropriate for runtime dependency injection, and the separation between token and first draft preferences will enable type-safe injection throughout the app.app/src/main/java/com/sopt/clody/data/local/datasource/FirstDraftLocalDataSource.kt (1)
8-11: Well-designed interface for draft state management.The interface provides a clean abstraction with clear property names and good documentation. Using
varproperties is appropriate for this SharedPreferences-backed data source pattern.app/src/main/java/com/sopt/clody/di/TokenDataStoreModule.kt (1)
18-18: Correct application of the new qualifier system.Adding the
@TokenPrefsqualifier ensures the correctSharedPreferencesinstance is injected, preventing potential conflicts with other preference instances and making the dependency injection more explicit.app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeScreen.kt (4)
6-6: New imports properly organized for UI enhancements.The imported components (
ClodyButton,ClodyPopupBottomSheet,ClodyToastMessage) are appropriately added to support the new first draft notification feature.Also applies to: 9-9, 14-14, 21-21, 24-24, 28-28, 33-33, 35-37
67-69: State management correctly implemented for new UI features.The new state flows for
showFirstDraftPopupanddraftAlarmEnableToastare properly collected and will reactively update the UI when changed by the ViewModel.
182-191: Toast implementation provides good user feedback.The toast correctly confirms the draft alarm enablement with appropriate styling, duration (3 seconds), and auto-dismiss functionality.
263-263: Clean formatting improvement for empty when branches.The explicit empty block syntax
{}improves readability compared to having completely empty branches.Also applies to: 291-291
app/src/main/java/com/sopt/clody/data/local/datasourceimpl/FirstDraftLocalDataSourceImpl.kt (1)
1-23: LGTM! Clean SharedPreferences implementation.The implementation follows Android best practices for SharedPreferences usage with proper dependency injection and encapsulation.
app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
| fun enableDraftAlarm(context: Context) { | ||
| viewModelScope.launch { | ||
| val fcmToken = getFcmToken(context) ?: return@launch | ||
| val notificationInfo = getNotificationInfo() ?: return@launch | ||
| val request = buildDraftAlarmRequest(notificationInfo, fcmToken) | ||
| sendDraftAlarmRequest(request) | ||
| } | ||
| } |
There was a problem hiding this comment.
Add network availability check for consistency.
The enableDraftAlarm function makes API calls but doesn't check network availability, unlike other functions in this ViewModel (loadCalendarData, loadDailyDiariesData). Add a network check for consistency and better error handling.
fun enableDraftAlarm(context: Context) {
viewModelScope.launch {
+ if (!networkUtil.isNetworkAvailable()) {
+ _draftAlarmChangeState.value = NotificationChangeState.Failure("네트워크 연결을 확인해주세요.")
+ return@launch
+ }
val fcmToken = getFcmToken(context) ?: return@launch
val notificationInfo = getNotificationInfo() ?: return@launch
val request = buildDraftAlarmRequest(notificationInfo, fcmToken)
sendDraftAlarmRequest(request)
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fun enableDraftAlarm(context: Context) { | |
| viewModelScope.launch { | |
| val fcmToken = getFcmToken(context) ?: return@launch | |
| val notificationInfo = getNotificationInfo() ?: return@launch | |
| val request = buildDraftAlarmRequest(notificationInfo, fcmToken) | |
| sendDraftAlarmRequest(request) | |
| } | |
| } | |
| fun enableDraftAlarm(context: Context) { | |
| viewModelScope.launch { | |
| if (!networkUtil.isNetworkAvailable()) { | |
| _draftAlarmChangeState.value = NotificationChangeState.Failure("네트워크 연결을 확인해주세요.") | |
| return@launch | |
| } | |
| val fcmToken = getFcmToken(context) ?: return@launch | |
| val notificationInfo = getNotificationInfo() ?: return@launch | |
| val request = buildDraftAlarmRequest(notificationInfo, fcmToken) | |
| sendDraftAlarmRequest(request) | |
| } | |
| } |
🤖 Prompt for AI Agents
In app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt
around lines 206 to 213, the enableDraftAlarm function lacks a network
availability check before making API calls. Add a check for network connectivity
at the start of the function, similar to the approach used in loadCalendarData
and loadDailyDiariesData, and handle the case where the network is unavailable
by returning early or notifying the user appropriately.
| private suspend fun getFcmToken(context: Context): String? { | ||
| val token = getTokenFromPreferences(context) | ||
| if (token.isNullOrBlank()) { | ||
| _draftAlarmChangeState.value = NotificationChangeState.Failure("FCM Token을 가져오는데 실패했습니다.") | ||
| return null | ||
| } | ||
| return token | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Implement token retrieval locally to reduce coupling.
Instead of importing getTokenFromPreferences from a companion object, implement it locally like other ViewModels in the codebase do (see TimeReminderViewModel and NotificationSettingViewModel).
-private suspend fun getFcmToken(context: Context): String? {
- val token = getTokenFromPreferences(context)
+private fun getFcmToken(context: Context): String? {
+ val sharedPreferences = context.getSharedPreferences("fcm_prefs", Context.MODE_PRIVATE)
+ val token = sharedPreferences.getString("fcm_token", null)
if (token.isNullOrBlank()) {
_draftAlarmChangeState.value = NotificationChangeState.Failure("FCM Token을 가져오는데 실패했습니다.")
return null
}
return token
}Also note that this function doesn't need to be suspend as it doesn't perform any suspending operations.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| private suspend fun getFcmToken(context: Context): String? { | |
| val token = getTokenFromPreferences(context) | |
| if (token.isNullOrBlank()) { | |
| _draftAlarmChangeState.value = NotificationChangeState.Failure("FCM Token을 가져오는데 실패했습니다.") | |
| return null | |
| } | |
| return token | |
| } | |
| private fun getFcmToken(context: Context): String? { | |
| val sharedPreferences = context.getSharedPreferences("fcm_prefs", Context.MODE_PRIVATE) | |
| val token = sharedPreferences.getString("fcm_token", null) | |
| if (token.isNullOrBlank()) { | |
| _draftAlarmChangeState.value = NotificationChangeState.Failure("FCM Token을 가져오는데 실패했습니다.") | |
| return null | |
| } | |
| return token | |
| } |
🤖 Prompt for AI Agents
In app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt
around lines 215 to 222, the getFcmToken function currently calls
getTokenFromPreferences from a companion object, creating unnecessary coupling,
and is marked suspend without needing to be. Refactor by implementing the token
retrieval logic locally within this ViewModel, similar to the approach in
TimeReminderViewModel and NotificationSettingViewModel, and remove the suspend
modifier since no suspending operations are performed.
app/src/main/java/com/sopt/clody/data/local/datasourceimpl/FirstDraftLocalDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
| private val diaryRepository: DiaryRepository, | ||
| private val notificationRepository: NotificationRepository, | ||
| private val networkUtil: NetworkUtil, | ||
| private val firstDraftLocalDataSource: FirstDraftLocalDataSource, |
There was a problem hiding this comment.
P2
이렇게 DataSource를 가져다써도 큰 문제는 없을 것 같긴 한데
viewmodel - repository pattern을 지키고 싶으면 아래와 같은 방법으로도 할 수 있을 것 같아요
interface DraftRepository {
fun isFirstUse(): Boolean
fun setFirstUse(value:Boolean)
}
class DraftRepositoryImpl @Inject Constructor
override fun isFirstUse(): Boolean= firstDraftLocalDataSource.isFirstUseThere was a problem hiding this comment.
사실 DataSource를 가져다 쓰는 구조는 지금까지의 코드 구조(Repository Pattern)를 많이 해치는 거 같아 조금 찝찝하긴합니다. 그래서 패턴을 따르도록 개선을 해야할 것 같기는 한데,
여기서 고민이 되는 것은 현재 FirstDraftLocalDataSource는 1. 일기를 2. 임시저장하는 기능 처음 사용할 경우 3. 알림 설정을 돕기 위한 기능이다보니 .. DiaryRepository, NotificationRepository, DraftRepository(신규 생성) 중 어디로 들어가야할 지에 대한 것입니다!
DraftRepository를 새로 만들기에는 기존 두개에 충분히 들어갈만 하지 않을까하는 생각이 들고, Repository의 개수가 늘어날수록 의미가 퇴색된다고 생각이 돼서 혹시 어디로 들어가는게 좋을 것 같다고 생각하시나요?
There was a problem hiding this comment.
흠...저는 Repository구분을 할때 "책임" 단위로 분리를 해는 방법이 좋은 방법이라고 생각합니다.
그래서 의미 있는 독립된 도메인이라면 Repository 수는 늘어나도 괜찮다고 생각하거덩여.
DiaryRepository, NotificationRepository 에 넣는 케이스일 경우 서버API와 로컬 SharedPreferences가 섞이는 이슈가 발생 하겠죠 아마도...?
FirstDraftLocalDataSource는 기기 내부적 플래그 역할을 해서 독립적인 도메인의 의미를 갖는다. 라고 생각해서 분리하는 쪽으로 생각을 했습니다...!
There was a problem hiding this comment.
DraftRepository를 만들면 뭔가 이름상 임시저장 조회/쓰기 API도 이쪽으로 옮겨야하지 않을까요? 이름을 바꿔야하나 ㅜ
제가 이해한 Repository Pattern으로는 로컬과 서버API가 섞이는 것은 필연적이라고 생각을 합니다. 데이터의 출처와 관계없이 하나의 Repository(저장소)에서 오는 data라고 속이는(?) 패턴이라고 생각해서요! 섞이면 발생하는 문제가 있을까요?
There was a problem hiding this comment.
아 맞다 리포지토리는 local, remote datasource가 섞여도 된다는걸 간과하고 있었습니다ㅋㅋㅋ...
말씀하신대로 "임시"fetch/save를 아예 분리 할까요 그냥?
| class WriteDiaryViewModel @Inject constructor( | ||
| private val diaryRepository: DiaryRepository, | ||
| private val networkUtil: NetworkUtil, | ||
| private val firstDraftLocalDataSource: FirstDraftLocalDataSource, |
| ) | ||
|
|
||
| if (showFirstDraftPopup) { | ||
| ClodyPopupBottomSheet( |
There was a problem hiding this comment.
P4
Route는 UI 상태 구독과 조립만 담당하는게 좋지 않을까요? 물론 방학시즌에 홈화면 개편이 들어갈 예정이니 요건 고려해보시고 바꿔주시면 될 것 같습니다~
| if (draftAlarmEnableToast) { | ||
| ClodyToastMessage( |
There was a problem hiding this comment.
P4
요 친구를 Route에 둔 이유가 있을까요?
There was a problem hiding this comment.
UI 상태 구독과 더불어 SideEffect 적인 것들은 Route에서 처리하는 것이 자연스럽다고 생각했습니다.
추후 MVI 구조를 적용한다고 생각했을때,
Screen에서 SideEffect를 트리거 -> Route에서 해당 SideEffect를 수집해서 토스트 노출
이 토스트 코드의 책임(?)을 다시 Screen에서 지는게 왔다리갔다리..? 같이 생각이 돼서 UiState가 성공한 화면에 대해서만 Screen에 정의하고 그 외는 Route에 위치시켰습니다. 그런데 지금 생각하니 또 확신이 잘 안서기는 하네요. HomeScreen이 리팩토링할 부분이 워낙 많아서 ..! Route에서 져야할 책임과 Screen에서 져야하는 책임은 무엇일까요?
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/src/main/java/com/sopt/clody/domain/repository/DraftRepository.kt (1)
3-8: Add documentation and consider more domain-focused naming.The interface lacks documentation explaining what these boolean flags represent. Additionally, consider if the interface name
DraftRepositoryaccurately reflects its responsibility of managing usage flags rather than draft content.Consider adding KDoc documentation:
+/** + * Repository for managing draft usage state and first-time use tracking. + */ interface DraftRepository { + /** + * Checks if draft functionality has been used before. + * @return true if draft has been used, false otherwise + */ fun getIsDraftUsed(): Boolean + /** + * Sets the draft usage state. + * @param state true to mark draft as used, false otherwise + */ fun setIsDraftUsed(state: Boolean) + /** + * Checks if this is the first time using the feature. + * @return true if first use, false otherwise + */ fun getIsFirstUse(): Boolean + /** + * Sets the first use state. + * @param state true to mark as first use, false otherwise + */ fun setIsFirstUse(state: Boolean) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
app/src/main/java/com/sopt/clody/data/repositoryimpl/DraftRepositoryImpl.kt(1 hunks)app/src/main/java/com/sopt/clody/di/RepositoryModule.kt(2 hunks)app/src/main/java/com/sopt/clody/domain/repository/DraftRepository.kt(1 hunks)app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt(4 hunks)app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryViewModel.kt(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- app/src/main/java/com/sopt/clody/data/repositoryimpl/DraftRepositoryImpl.kt
🚧 Files skipped from review as they are similar to previous changes (2)
- app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryViewModel.kt
- app/src/main/java/com/sopt/clody/presentation/ui/home/screen/HomeViewModel.kt
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
app/src/main/java/com/sopt/clody/di/RepositoryModule.kt (1)
7-7: LGTM: Consistent dependency injection pattern.The import additions and repository binding follow the established pattern used by other repositories in this module. The implementation correctly uses
@Bindsand@Singletonannotations for proper dependency injection.Also applies to: 15-15, 70-74
| package com.sopt.clody.domain.repository | ||
|
|
||
| interface DraftRepository { | ||
| fun getIsDraftUsed(): Boolean | ||
| fun setIsDraftUsed(state: Boolean) | ||
| fun getIsFirstUse(): Boolean | ||
| fun setIsFirstUse(state: Boolean) | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider making repository methods suspend functions for better async handling.
The synchronous methods may cause ANR issues if the underlying SharedPreferences operations block the main thread. Consider making these suspend functions to align with modern Android development practices.
Apply this diff to make the methods asynchronous:
interface DraftRepository {
- fun getIsDraftUsed(): Boolean
- fun setIsDraftUsed(state: Boolean)
- fun getIsFirstUse(): Boolean
- fun setIsFirstUse(state: Boolean)
+ suspend fun getIsDraftUsed(): Boolean
+ suspend fun setIsDraftUsed(state: Boolean)
+ suspend fun getIsFirstUse(): Boolean
+ suspend fun setIsFirstUse(state: Boolean)
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| package com.sopt.clody.domain.repository | |
| interface DraftRepository { | |
| fun getIsDraftUsed(): Boolean | |
| fun setIsDraftUsed(state: Boolean) | |
| fun getIsFirstUse(): Boolean | |
| fun setIsFirstUse(state: Boolean) | |
| } | |
| package com.sopt.clody.domain.repository | |
| interface DraftRepository { | |
| suspend fun getIsDraftUsed(): Boolean | |
| suspend fun setIsDraftUsed(state: Boolean) | |
| suspend fun getIsFirstUse(): Boolean | |
| suspend fun setIsFirstUse(state: Boolean) | |
| } |
🤖 Prompt for AI Agents
In app/src/main/java/com/sopt/clody/domain/repository/DraftRepository.kt lines 1
to 8, the repository methods are synchronous which can block the main thread and
cause ANR issues. Modify all methods in the DraftRepository interface to be
suspend functions by adding the suspend modifier before each function
declaration to enable asynchronous execution and better align with modern
Android development practices.
| private val diaryRepository: DiaryRepository, | ||
| private val notificationRepository: NotificationRepository, | ||
| private val networkUtil: NetworkUtil, | ||
| private val firstDraftLocalDataSource: FirstDraftLocalDataSource, |
There was a problem hiding this comment.
아 맞다 리포지토리는 local, remote datasource가 섞여도 된다는걸 간과하고 있었습니다ㅋㅋㅋ...
말씀하신대로 "임시"fetch/save를 아예 분리 할까요 그냥?
2 participants
📌 ISSUE
closed #268
📄 Work Description
1. 임시저장 최초 여부 판별
📱 일기쓰기 화면 내 로직
유저가 일기를 작성하다가 홈화면으로 이동하기 위해 뒤로가기를 누른다.
임시저장 의사를 묻는 다이얼로그가 출력된다.
임시저장 하고 나가기를 선택하였을 경우
isDraftUsed == false: 최초 사용을 의미하므로isDraftUsed, isFirstUse를true로 변경isDraftUsed == true: 아무 추가 동작없이 저장 후 홈화면으로 이동한다.📱 홈 화면 내 로직
홈 화면에 진입 시
isFirstUse값을 검사한다.true→ 이어쓰기 알림설정을 위한 바텀시트를 노출시킨다.false→ 아무 추가 동작도 하지 않는다.위 로직 구현을 위해 SharedPreferences로 flag 관리하도록 했습니다.
2. 이어쓰기 알림설정 바텀시트
사용자의 알림 권한 설정 여부와 상관없이 무조건 이어쓰기 알림설정을 활성화하는 방향으로 구현한다.
유저가 하나의 알림이라도 받고 있을 경우
→ 해당 시간과 동일하게 이어쓰기 알림설정 활성화
유저가 어떤 알림도 받지 않고 있을 경우
→ 이어쓰기 알림 활성화 + 시간은 21:30 으로 설정
✨ PR Point
📸 ScreenShot/Video
268-draft.mp4
Summary by CodeRabbit
New Features
Enhancements
Chores