Conversation
- fetch 간격을 10분으로 설정하여 더 자주 업데이트를 가져오도록 수정했습니다.
WalkthroughThe changes update the Firebase RemoteConfig fetch interval to 600 seconds, conditionally render the diary delete button based on diary content, fix the default time picker value for reminders, and adjust diary writing screen padding to correctly account for the keyboard and navigation bar insets. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant FirebaseRemoteConfig
User->>App: Launch app
App->>FirebaseRemoteConfig: Get instance
App->>FirebaseRemoteConfig: Apply config settings (minFetchInterval=600)
FirebaseRemoteConfig-->>App: Configured instance returned
sequenceDiagram
participant User
participant DiaryScreen
User->>DiaryScreen: View daily diary list
alt Diaries exist
DiaryScreen->>User: Show delete (kebab) button
else No diaries
DiaryScreen->>User: Hide delete button
end
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/src/main/java/com/sopt/clody/presentation/ui/home/calendar/component/DailyDiaryListItem.kt (1)
65-73: Localize the icon’s content description
contentDescriptionis hard-coded as an English literal. Consider usingstringResource(R.string.… )so it’s translated alongside the rest of the UI, and to keep accessibility wording consistent.app/src/main/java/com/sopt/clody/di/AppUpdateModule.kt (1)
20-27: Consider environment-specific fetch intervalsA 600-second minimum fetch interval is sensible for production, but it slows iteration in debug builds.
You can conditionally shorten it for debuggable builds:val minFetch = if (BuildConfig.DEBUG) 0L else 600L remoteConfig.setConfigSettingsAsync( FirebaseRemoteConfigSettings.Builder() .setMinimumFetchIntervalInSeconds(minFetch) .build() )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/src/main/java/com/sopt/clody/di/AppUpdateModule.kt(2 hunks)app/src/main/java/com/sopt/clody/presentation/ui/auth/timereminder/TimeReminderScreen.kt(1 hunks)app/src/main/java/com/sopt/clody/presentation/ui/home/calendar/component/DailyDiaryListItem.kt(1 hunks)app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryScreen.kt(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
app/src/main/java/com/sopt/clody/presentation/ui/auth/timereminder/TimeReminderScreen.kt (1)
103-107: Double-check hour formatting
viewModel.setFixedTime(TimePeriod.PM, "9", "30")now passes"9"(no leading zero).
If the downstream formatter assumes two-digit hours ("09"), the UI may show an unexpected value or validation could fail. Please verify all consumers accept the one-digit form.app/src/main/java/com/sopt/clody/presentation/ui/writediary/screen/WriteDiaryScreen.kt (1)
253-258: 👍 Keyboard-aware padding looks goodThe dynamic
contentPaddingcleanly subtracts the scaffold’s bottom inset and clamps at zero—this should resolve the previous IME overlap without over-scroll. Nice fix.
2 participants
📌 ISSUE
closed #294
📄 Work Description
✨ PR Point
📸 ScreenShot/Video
Summary by CodeRabbit