Skip to content

[Fix/#306] Amplitude 초기화로 인한 앱 크래시 문제를 해결합니다.#307

Merged
SYAAINN merged 1 commit intodevelopfrom
fix/#306-amplitude-init-fix
Jul 17, 2025
Merged

[Fix/#306] Amplitude 초기화로 인한 앱 크래시 문제를 해결합니다.#307
SYAAINN merged 1 commit intodevelopfrom
fix/#306-amplitude-init-fix

Conversation

@SYAAINN
Copy link
Contributor

@SYAAINN SYAAINN commented Jul 17, 2025

📌 ISSUE

closed #306

📄 Work Description

앰플리튜드 분기처리 다시 삭제했습니다 .. 추후 다시 적용하는 것으로 하겠습니다 ㅜ

Summary by CodeRabbit

  • Chores
    • Analytics tracking will now be initialized in all app builds, including debug versions.

@SYAAINN SYAAINN requested a review from MoonsuKang July 17, 2025 02:38
@SYAAINN SYAAINN self-assigned this Jul 17, 2025
@SYAAINN SYAAINN added 🔥 민재 민재 🛠️ FIX 버그 및 문제 해결 labels Jul 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 17, 2025

Walkthrough

The code change removes the conditional check that restricted Amplitude SDK initialization to non-debug builds, making Amplitude initialization occur in all build configurations during application startup.

Changes

File(s) Change Summary
app/src/main/java/com/sopt/clody/ClodyApplication.kt Removed build config check; Amplitude is now always initialized.

Assessment against linked issues

Objective Addressed Explanation
Prevent crash caused by calling trackEvent when Amplitude is not initialized (#306)
Ensure Amplitude is initialized in debug builds to avoid uninitialized usage (#306)

Poem

The clouds above are crystal clear,
No crashes now, so never fear!
Amplitude starts with every run,
Debug or not, the job is done.
The bunny hops, the bug is gone—
Let’s celebrate and code along! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e301099 and d0b558c.

📒 Files selected for processing (1)
  • app/src/main/java/com/sopt/clody/ClodyApplication.kt (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
app/src/main/java/com/sopt/clody/ClodyApplication.kt (1)
app/src/main/java/com/sopt/clody/presentation/utils/amplitude/AmplitudeUtils.kt (1)
  • initAmplitude (12-19)
🔇 Additional comments (1)
app/src/main/java/com/sopt/clody/ClodyApplication.kt (1)

19-19: Approve Crash Fix; Verify Analytics Configuration

LGTM: Removing the conditional around initAmplitude(applicationContext) correctly addresses the crash.

Before reapplying any debug/release branching, please verify and address the following:

  • Confirm that BuildConfig.AMPLITUDE_API_KEY is defined for all build variants (check your app/build.gradle(.kts) or gradle.properties).
  • Consider using a separate debug API key or disabling Amplitude in debug builds to avoid sending development data to production analytics.
  • Wrap the call to initAmplitude in a try–catch block to guard against any future misconfiguration or unexpected runtime errors.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SYAAINN SYAAINN merged commit 6178853 into develop Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔥 민재 민재 🛠️ FIX 버그 및 문제 해결

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Amplitude 초기화로 인한 앱 크래시 문제를 해결합니다.

2 participants