Conversation
Closed
1 task
sonms
approved these changes
Mar 27, 2026
| converterFactory: Converter.Factory | ||
| ): Retrofit = Retrofit.Builder() | ||
| .baseUrl(BuildConfig.BASE_URL) | ||
| .baseUrl(if (BuildConfig.DEBUG) BuildConfig.DEBUG_BASE_URL else BuildConfig.BASE_URL) //BuildConfig.BASE_URL) |
Comment on lines
+24
to
+40
| fun RoutePostDto.toEntity() = RoutePostEntity( | ||
| postId = postId, | ||
| regionName = regionName, | ||
| title = title, | ||
| date = date, | ||
| durationMinutes = durationMinutes, | ||
| isLiked = isLiked, | ||
| imageUrl = imageUrl, | ||
| ) | ||
|
|
||
| fun ReviewPostDto.toEntity() = ReviewPostEntity( | ||
| postId = postId, | ||
| title = title, | ||
| regionName = regionName, | ||
| date = date, | ||
| categoryOptionSummary = categoryOptionSummary, | ||
| ) No newline at end of file |
Member
There was a problem hiding this comment.
우리 이제 클린이라 dto안에 toEntity 가 존재해야합니다!
의존성 바뀌었어요 도하하~
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/model/CourseType.kt
Outdated
Show resolved
Hide resolved
| val isLiked: Boolean = false, | ||
| val categoryOptionSummary: List<String> = emptyList(), |
Member
There was a problem hiding this comment.
List는 컬렉션으로 가짜 불변이에요!
ImmutableList를 사용해주세요~
아래에 CourseInfoState도 마찬가지입니다~!
Comment on lines
+23
to
+30
| composable<CourseInfoNavRoute> { backStackEntry -> | ||
| val route = backStackEntry.toRoute<CourseInfoNavRoute>() | ||
| CourseInfoRoute( | ||
| navigateUp = navigateUp, | ||
| courseType = route.courseType, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Serializable | ||
| data class CourseInfo( | ||
| val courseType: String, | ||
| ) No newline at end of file | ||
| } |
Member
There was a problem hiding this comment.
아래 viewmodel에서도 savedStateHandle 로 가져와서 사용하고 있는 것 같아요! 확인 부탁드립니다~
Comment on lines
+48
to
+54
| LaunchedEffect(Unit) { | ||
| viewModel.sideEffect.collect { effect -> | ||
| when (effect) { | ||
| is CourseInfoSideEffect.ShowSnackBar -> snackbarHostState.showSnackbar(effect.message) | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
viewmodel.sideeffect.collectSideEffect 로 변경 부탁드려요~
Comment on lines
+39
to
+51
| LaunchedEffect(viewModel.sideEffect) { | ||
| viewModel.sideEffect.collect { effect -> | ||
| when (effect) { | ||
| is UserProfileSideEffect.ShowSnackBar -> { | ||
| Toast.makeText(context, effect.message, Toast.LENGTH_SHORT).show() | ||
| } | ||
| is UserProfileSideEffect.NavigateUp -> { | ||
| navigateUp() | ||
| } | ||
| else -> Unit | ||
| } | ||
| } | ||
| } |
|
|
||
| testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" | ||
| buildConfigField("String", "BASE_URL", properties["base.url"].toString()) | ||
| buildConfigField("String", "DEBUG_BASE_URL", properties["debug.base.url"].toString()) // ✅ 여기로 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
❗ WORK DESCRIPTION
📸 SCREENSHOT
📢 TO REVIEWERS