Skip to content

[feat] #128 포인트 차감 기능 구현 및 트랜잭션 타입 분기 처리 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2hyunjinn merged 2 commits into from
May 14, 2025
Merged

[feat] #128 포인트 차감 기능 구현 및 트랜잭션 타입 분기 처리 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2eca6
[feat] #128 포인트 차감 기능 구현
2hyunjinn May 14, 2025
9c089f3
[test] #128 포인트 관련 테스트 코드 수정
2hyunjinn May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/org/festimate/team/api/facade/PointFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import org.festimate.team.domain.festival.service.FestivalService;
import org.festimate.team.domain.participant.entity.Participant;
import org.festimate.team.domain.participant.service.ParticipantService;
import org.festimate.team.domain.point.entity.TransactionType;
import org.festimate.team.domain.point.service.PointService;
import org.festimate.team.domain.user.entity.User;
import org.festimate.team.domain.user.service.UserService;
Expand Down Expand Up @@ -51,7 +52,12 @@ public void rechargePoints(Long userId, Long festivalId, RechargePointRequest re
if (participant.getFestival() != festival) {
throw new FestimateException(ResponseError.FORBIDDEN_RESOURCE);
}
pointService.rechargePoint(participant, request.point());

if(request.type().equals(TransactionType.CREDIT)) {
pointService.rechargePoint(participant, request.point());
}else if (request.type().equals(TransactionType.DEBIT)) {
pointService.dischargePoint(participant, request.point());
}
}

private void isHost(User user, Festival festival) {
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/festimate/team/api/point/dto/RechargePointRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package org.festimate.team.api.point.dto;

import org.festimate.team.domain.point.entity.TransactionType;

public record RechargePointRequest(
TransactionType type,
long participantId,
int point
) {
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/festimate/team/domain/point/service/PointService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,8 @@ public interface PointService {

@Transactional
void rechargePoint(Participant participant, int amount);

@Transactional
void dischargePoint(Participant participant, int amount);

}
15 changes: 13 additions & 2 deletions src/main/java/org/festimate/team/domain/point/service/impl/PointServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
import lombok.extern.slf4j.Slf4j;
import org.festimate.team.api.point.dto.PointHistory;
import org.festimate.team.api.point.dto.PointHistoryResponse;
import org.festimate.team.domain.participant.entity.Participant;
import org.festimate.team.domain.point.entity.Point;
import org.festimate.team.domain.point.entity.TransactionType;
import org.festimate.team.domain.point.repository.PointRepository;
import org.festimate.team.domain.point.service.PointService;
import org.festimate.team.global.response.ResponseError;
import org.festimate.team.global.exception.FestimateException;
import org.festimate.team.domain.participant.entity.Participant;
import org.festimate.team.global.response.ResponseError;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

Expand Down Expand Up @@ -54,6 +54,17 @@ public void rechargePoint(Participant participant, int amount) {
pointRepository.save(pointUsage);
}

@Transactional
@Override
public void dischargePoint(Participant participant, int amount) {
int totalPoint = getTotalPointByParticipant(participant);
if (totalPoint < amount) {
throw new FestimateException(ResponseError.INSUFFICIENT_POINTS);
}
Point pointUsage = createPointTransaction(participant, amount, TransactionType.DEBIT);
pointRepository.save(pointUsage);
}

private Point createPointTransaction(Participant participant, int amount, TransactionType type) {
return Point.builder()
.participant(participant)
Expand Down
7 changes: 4 additions & 3 deletions src/test/java/org/festimate/team/api/facade/PointFacadeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import org.festimate.team.domain.festival.service.FestivalService;
import org.festimate.team.domain.participant.entity.Participant;
import org.festimate.team.domain.participant.service.ParticipantService;
import org.festimate.team.domain.point.entity.TransactionType;
import org.festimate.team.domain.point.service.PointService;
import org.festimate.team.domain.user.entity.Gender;
import org.festimate.team.domain.user.entity.User;
Expand Down Expand Up @@ -97,7 +98,7 @@ void getParticipantPointHistory_success() {
@DisplayName("포인트 충전 성공 (호스트 권한)")
void rechargePoints_success() {
// given
RechargePointRequest request = new RechargePointRequest(200L, 5);
RechargePointRequest request = new RechargePointRequest(TransactionType.CREDIT, 200L, 5);

when(userService.getUserByIdOrThrow(1L)).thenReturn(host);
when(festivalService.getFestivalByIdOrThrow(100L)).thenReturn(festival);
Expand All @@ -115,7 +116,7 @@ void rechargePoints_success() {
@DisplayName("포인트 충전 실패 - 호스트가 아님")
void rechargePoints_notHost_throws() {
User attacker = MockFactory.mockUser("악당", Gender.MAN, 999L);
RechargePointRequest request = new RechargePointRequest(200L, 5);
RechargePointRequest request = new RechargePointRequest(TransactionType.CREDIT, 200L, 5);

when(userService.getUserByIdOrThrow(999L)).thenReturn(attacker);
when(festivalService.getFestivalByIdOrThrow(100L)).thenReturn(festival);
Expand All @@ -133,7 +134,7 @@ void rechargePoints_participantMismatch_throws() {
Festival otherFestival = MockFactory.mockFestival(host, 999L, LocalDate.now(), LocalDate.now().plusDays(1));
Participant otherParticipant = MockFactory.mockParticipant(participantUser, otherFestival, null, 300L);

RechargePointRequest request = new RechargePointRequest(300L, 5);
RechargePointRequest request = new RechargePointRequest(TransactionType.CREDIT, 300L, 5);

when(userService.getUserByIdOrThrow(1L)).thenReturn(host);
when(festivalService.getFestivalByIdOrThrow(100L)).thenReturn(festival);
Expand Down