Open
Conversation
… mod-#114-journey-sprint-qa
seungjae708
requested review from
dmp100,
sonms and
vvan2
and removed request for
a team
1 task
sonms
approved these changes
Mar 23, 2026
Member
sonms
left a comment
sonms
left a comment
There was a problem hiding this comment.
고생하셨습니다!!!
Timber의 companion object인 forest만 생략해주셔서 가독성을 올려주시면 감사하겠습니다~~
| }.stateIn( | ||
| scope = viewModelScope, | ||
| started = SharingStarted.WhileSubscribed(5_000), | ||
| started = SharingStarted.Companion.WhileSubscribed(5_000), |
Comment on lines
+57
to
+74
| @@ -71,7 +71,7 @@ class KidMissionViewModel @Inject constructor( | |||
| fun collectChildMissionEvents() { | |||
| viewModelScope.launch { | |||
| sseManager.childMissionEvents.collect { event -> | |||
| Timber.e("collectChildMissionEvents $event") | |||
| Timber.Forest.e("collectChildMissionEvents $event") | |||
Member
There was a problem hiding this comment.
p1: 이것도 forest 생략 부탁드려용
가독성이 떨어지는 것 같습니다
vvan2
approved these changes
Mar 23, 2026
| SseEventType.COUPON -> { | ||
| try { | ||
| val data = json.decodeFromString<CouponDataDto>(raw.data) | ||
| Timber.d("🎟️ Coupon 이벤트 파싱 성공: ${data.couponName}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
❗ WORK DESCRIPTION
여정 & 맵 화면 (Journey & Map)
미션 & 소원 화면 (Mission & Wish)
공통 컴포넌트 & 온보딩