[FEAT] auth UI refactor#52
Merged
Merged
Conversation
Contributor
Author
충돌 해결했습니다! yarn.lock에서 버전이 업데이트된 내용이 있었는데, 그걸 최신화 안했었네요! |
IISweetHeartII
added
fix
…into feature/auth-UI-refactor-#50
…ure/auth-UI-refactor-#50
…-web into feature/auth-UI-refactor-#50
Head-ddy
approved these changes
Jul 12, 2025
| {apiError} | ||
| </div> | ||
| )} | ||
| <div className="flex flex-col items-center gap-1 pt-1 text-[13px] text-[#828282]"> |
Contributor
There was a problem hiding this comment.
text-[13px] 이 부분만 rem단위로 변경해주시면 좋을 것 같아요!
| onClick={handleWrapperClick} | ||
| className="fixed inset-0 z-50 flex items-center justify-center bg-black bg-opacity-40" | ||
| > | ||
| <div className="flex flex-col items-center gap-6 bg-white rounded-lg p-6 w-[300px] text-center"> |
Contributor
There was a problem hiding this comment.
여기도 px rem으로 변경하면 좋을 것 같습니다!
| @@ -25,7 +26,7 @@ export default function LoginPage() { | |||
| // 가상의 로그인 실패 시나리오 | |||
| await new Promise((resolve) => setTimeout(resolve, 1000)); | |||
| console.log(data); | |||
Contributor
There was a problem hiding this comment.
나중에 배포하기 전에는 console.log 지워주셔도 될 거 같아요!
Contributor
There was a problem hiding this comment.
앗 그리고 사용자한테 보여주고 싶은 에러메시지는 toast 공용 컴포넌트 활용해도 좋을 거 같아요!
theSnackOverflow
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Pull Request Title
로그인/회원가입/비밀번호찾기/초기화 화면 UI 디자인
📌 PR 설명
이번 PR에서 어떤 작업을 했는지 요약해주세요.
📷 스크린샷
🔍 추가 설명