Skip to content

Conversation

@GanziMan
Copy link
Collaborator

@GanziMan GanziMan commented Jun 29, 2025

어떤 이유로 리팩토링했는지 간단히 설명해주세요.

  • 데이트 피커 연도 단위 기능 개발

✅ 변경 사항

  • 학생등록/ 진급 기능 등 날짜 선택 기능이 필요한 곳에 데이트피커 적용

🧪 테스트

  • [] 기존 테스트 케이스로 정상 동작 확인

🔗 관련 이슈 (선택)

  • 예창패 노션 오프라인 미팅

@GanziMan GanziMan requested review from Copilot and goldf0yle June 29, 2025 15:34
@GanziMan GanziMan added the refactor code refactoring label Jun 29, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces custom date string handling in the attendee creation form with a dedicated date picker drawer component and refactors related UI elements.

  • Removed manual date formatting logic and integrated DateDrawer with dayjs for birth and enrollment dates
  • Added state and handlers to open the drawer and set form values on date selection
  • Updated inputs to be read-only with click triggers, extracted relationOptions, and standardized error message wrappers
Comments suppressed due to low confidence (2)

src/pages/book/book-attendee/attendee-create/_components/Step1.tsx:56

  • [nitpick] The function name handleCurrentDay is ambiguous; consider renaming it to handleBirthDateSelect to clearly indicate its purpose.
  const handleCurrentDay = useCallback(

src/pages/book/book-attendee/attendee-create/_components/Step1.tsx:306

  • The new DateDrawer component integration isn't covered by existing tests; consider adding unit or integration tests to verify drawer open/close behavior and ensure selected dates update the form correctly.
      <DateDrawer

@Team-Pond Team-Pond deleted a comment from Copilot AI Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants