Support for fetching admin list from SFTP source #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelhoral
force-pushed
the
feat-sftp-adminlist
branch
from
935b175 to
a4c1873
Compare
werewolfboy13
requested changes
Oct 19, 2024
Collaborator
werewolfboy13
left a comment
werewolfboy13
left a comment
There was a problem hiding this comment.
Apologies on the delay, this needs to be corrected to use the templates.
Contributor
Author
I am not sure I follow what needs to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fetching Admins.cfg file from SFTP source. I have also replaced manual regex based URL parsing with NodeJS's URL parsing.
I have tested both FTP and SFTP using local docker containers (https://github.com/garethflowers/docker-ftp-server and https://docs.sftpgo.com/).
I have used
ssh2-sftp-clientpackage because this exact package is being used by the current ftp-tail dependency (https://github.com/Thomas-Smyth/ftp-tail/). The major version is increased from 10 to 11, but I don't think that should break anything.