Lazy load fix for Blade-tailwind preset - #514
Open
roydebangshu wants to merge 3 commits into
Open
Conversation
* Modified scopeWithPostAndAuthorRelationships in Thread.php to eagerly load the category relation.
* Updated DEFAULT_WITH in CategoryAccess.php to use newestThread.lastPost.thread and latestActiveThread.lastPost.thread.
* Changed mount() in ThreadShow.php to manually execute $request->route('thread')->load('category')
* Modified render() in PostShow.php to run $post->load('thread.category').
* Changed mount() in ThreadReply.php to eager load category.
Replaced $this->thread->posts->find(...) with a database query $this->thread->posts()->find(...), ensuring we don't load the entire thread's post history into application memory.
in components.post.card view calling isset($post->parent) and in post.card view accesses $post->thread->category->requiresPostApproval(), was triggering lazy loading
Modified src/Http/Controllers/Blade/ThreadController.php so that when viewing a thread, the posts query eager loads parent, parent.author, parent.thread, and parent.thread.category. Modified src/Http/Controllers/Blade/PostController.php to explicitly load those same relationships when fetching a single post for viewing, editing, deleting, or restoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
Http/Controllers/Blade/ThreadController.phpso that when viewing a thread, theposts queryeager loadsparent,parent.author,parent.thread, andparent.thread.category.Modified Http/Controllers/Blade/PostController.php to explicitly load those same relationships when fetching a single
post for viewing, editing, deleting, or restoring.