Skip to content

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Sep 16, 2024

✨ Related Issue

📝 기능 구현 명세

🐥 추가적인 언급 사항

  • ErrorHandler에서는 val을 제거하면 아래처럼 각각의 ErrorCode의 위치까지 명시해주어야하기 때문에 제거하지 않았습니다.
com.tiki.server.memberteammanager.message.ErrorCode errorCode = exception.getErrorCode();

@Chan531 Chan531 requested a review from paragon0107 September 16, 2024 09:13
@Chan531 Chan531 self-assigned this Sep 16, 2024
Copy link
Contributor

@paragon0107 paragon0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
다만 에러코드를 val로 밖에 사용하지 못하는건 별로 좋지 못한 설계인것 같아서 추후 변경할 필요가 있어 보입니다!

@Chan531 Chan531 merged commit bfcba1f into develop Sep 18, 2024
1 check passed
@Chan531 Chan531 deleted the refactor/#148-type branch September 18, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] 타입 추론 지양

2 participants