Skip to content

[CHORE] 업데이트 시 작성자 일치 조건 삭제 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025
Merged

[CHORE] 업데이트 시 작성자 일치 조건 삭제 #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f957b2a
[CHORE] 업데이트 시 작성자 일치 조건 삭제
paragon0107 Mar 1, 2025
d0ebae0
[CHORE] 쓸모없는 import문 삭제
paragon0107 Mar 1, 2025
60b5ae4
[CHORE] 쓸모없는 Exception 삭제
paragon0107 Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions src/main/java/com/tiki/server/note/entity/Note.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
package com.tiki.server.note.entity;

import static com.tiki.server.note.message.ErrorCode.UPDATE_ONLY_BELONGING_TEAM;
import static jakarta.persistence.GenerationType.IDENTITY;
import static lombok.AccessLevel.PRIVATE;
import static lombok.AccessLevel.PROTECTED;

import com.tiki.server.common.entity.BaseTime;
import com.tiki.server.note.exception.NoteException;
import jakarta.persistence.*;
import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.EnumType;
import jakarta.persistence.Enumerated;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.Id;
import java.time.LocalDate;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
import lombok.NoArgsConstructor;

import java.time.LocalDate;

import static com.tiki.server.note.message.ErrorCode.UPDATE_ONLY_AUTHOR;
import static com.tiki.server.note.message.ErrorCode.UPDATE_ONLY_BELONGING_TEAM;
import static jakarta.persistence.GenerationType.IDENTITY;
import static lombok.AccessLevel.PRIVATE;
import static lombok.AccessLevel.PROTECTED;

@Entity
@Getter
@Builder
Expand Down Expand Up @@ -84,7 +87,6 @@ public void updateValue(
final boolean complete,
final NoteType noteType
) {
checkAuthor(clientId);
checkTeam(clientTeamId);
this.title = title;
this.contents = contents;
Expand All @@ -98,12 +100,6 @@ public void deleteMemberDependency() {
this.memberId = null;
}

private void checkAuthor(final long clientId) {
if (this.memberId != clientId) {
throw new NoteException(UPDATE_ONLY_AUTHOR);
}
}

private void checkTeam(final long clientTeamId) {
if (this.teamId != clientTeamId) {
throw new NoteException(UPDATE_ONLY_BELONGING_TEAM);
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/tiki/server/note/message/ErrorCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ public enum ErrorCode {
/* 400 BAD REQUEST : 잘못된 요청 */
TITLE_IS_EMPTY(BAD_REQUEST, "제목은 필수 입력값 입니다."),
TITLE_LENGTH_OVER(BAD_REQUEST, "제목은 100자를 넘길 수 없습니다."),
UPDATE_ONLY_AUTHOR(BAD_REQUEST, "수정은 작성자만 가능합니다."),
UPDATE_ONLY_BELONGING_TEAM(BAD_REQUEST, "해당 팀에 소속된 파일이 아닙니다."),

/* 404 NOT_FOUND : 자원을 찾을 수 없음 */
Expand Down