made paths #12
Open
made paths #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Ayidana-Aboraah
requested changes
Oct 28, 2023
Contributor
Ayidana-Aboraah
left a comment
Ayidana-Aboraah
left a comment
There was a problem hiding this comment.
Some small changes need
Ayidana-Aboraah
requested changes
Oct 28, 2023
Contributor
Ayidana-Aboraah
left a comment
Ayidana-Aboraah
left a comment
There was a problem hiding this comment.
The mistakes you made before seem to have been repeated here and there are some more stylistic issues.
|
|
||
| public class Inake extends CommandBase { | ||
|
|
||
| subWristem intake = new subWristem(); |
Contributor
There was a problem hiding this comment.
Should remove the intialisation and keep the object name and type.
| public Inake(subWristem intake) { | ||
| this.intake = intake; | ||
| addRequirements(intake); | ||
| // Use addRequirements() here to declare subsystem dependencies. |
Contributor
There was a problem hiding this comment.
Remove this comment.
| case 2: height = highHeight; //highest height | ||
| break; | ||
| } | ||
| // Use addRequirements() here to declare subsystem dependencies. |
Comment on lines
+15
to
+19
| elevator Elevator = new elevator(); | ||
| subWristem intake = new subWristem(); | ||
| public lowerElevator() { | ||
| // Use addRequirements() here to declare subsystem dependencies. | ||
| } |
Contributor
There was a problem hiding this comment.
Subsystems should be passed in as parameters and the addRequirments method should be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.