init commit #1
Open
init commit #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayidana-Aboraah
requested changes
Oct 7, 2023
Ayidana-Aboraah
left a comment
Ayidana-Aboraah
left a comment
There was a problem hiding this comment.
Mostly formatting changes and important configuration changes.
Comment on lines
+30
to
+31
| steerencoder.configMagnetOffset(encoderoffset); | ||
| steerencoder.configAbsoluteSensorRange(AbsoluteSensorRange.Unsigned_0_to_360); |
There was a problem hiding this comment.
Might want to configure statusFramePeriod and add timeouts. Sensor direction may also be a setting you want to configure.
| swervemotor.getEncoder().setPosition(0); | ||
| } | ||
|
|
||
| public void rotateto(double rotation){ |
| swervemotor.getEncoder().setPosition(Math.toRadians(steerencoder.getAbsolutePosition())); | ||
| } | ||
|
|
||
| public void move(double setSwerveMotorPosition, double drivemotorspeed){ |
| steerencoder.configAbsoluteSensorRange(AbsoluteSensorRange.Unsigned_0_to_360); | ||
| } | ||
|
|
||
| public void resetSteerPosition() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swerve drive code integrated with joystick.