Balance Just Dire Things fluid fuel values #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the fuel values, in EU/mB, of the three fluid fuels from Just Dire Things to fully take into account the fuel value of the JDT coal corresponding to each fluid tier. This makes it practical to produce JDT fluid fuels even after the reduction in JDT coal enrichment yields in the Ooze Lab from 1:1 to 9:4.
|
I like it. I'll leave this PR open for a bit the others on team speak to it. |
|
One change though... move this to the existing fluid_fuel.json file. |
Where can I find that file? |
|
Ah... my mistake. I mean, that file is part of MI itself, and is meant to be overwritten with a data/res pack. I guess best to leave your suggested changes in the data map file you used, as that lives in the same directory with other pack changes to MI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the fuel values, in EU/mB, of the three fluid fuels from Just Dire Things to fully take into account the fuel value of the JDT coal corresponding to each fluid tier. This makes it practical to produce JDT fluid fuels even after the reduction in JDT coal enrichment yields in the Ooze Lab from 1:1 to 9:4.
See comments on bf00911 and bbeff6e for justification and work showing JDT fuel production still produces a good return on investment while not being overpowered.