-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix: Improve spacing and styling for 'Try Indexed Search' button #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/4.0
Are you sure you want to change the base?
Fix: Improve spacing and styling for 'Try Indexed Search' button #4388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajay020 thanks, appreciate your interest in contributing to amaze! but, the UX in this PR deviates from the expected UX (https://github.com/orgs/TeamAmaze/discussions/3984). an option for indexed search never appears (edit: okay, it was not about the behaviour, t'was just about the display string, I presume). please take a look, thanks.
@VishnuSanal Thanks for the review! You're right — this PR only changes the display string and layout styling, not the actual behaviour. I went through the discussion, but I'm still unclear on what part might be deviating from the expected UX. Could you please clarify what you meant by "an option for indexed search never appears"? |
@VishnuSanal I realised I hadn’t updated the button text string as expected. Just pushed a fix to address that. Let me know if you'd prefer any other change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is better! but, I have some suggestions, PTAL at the commments
app/src/main/java/com/amaze/filemanager/ui/views/appbar/SearchView.java
Outdated
Show resolved
Hide resolved
236a93b
to
c73581f
Compare
In the layout file, I’ve reduced the internal padding and added a margin so that the text “Not finding what you're looking for” and the button “Try index search” now appear on a single line. phone preview tablet preview On smaller screens, the button text wraps into two lines due to limited space. If that doesn’t look good to you, I can try vertically stacking the text and the button instead. Let me know what you'd prefer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work! please address slight alignment issues, and we're golden, thx! :)
android:id="@+id/searchDeepSearchTV" | ||
android:layout_width="wrap_content" | ||
<LinearLayout | ||
android:id="@+id/deepSearchContainer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the same behaviour from the tablet layout here too.
i.e, to make the whole container fill width, and align both notFindingTextView
& tryDeepSearchButton
at both ends where the remaining space is filled. i.e, to right-align tryDeepSearchButton
.
but that's personal preference. let's wait for other maintainers to chime in :)
… button padding for better spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 awesome work! :)
Description
Improved layout and styling of the 'Try Indexed Search!' button to match expected UI guidelines.
Before
After
Tablet
Phone
Issue tracker
Fixes #4332
Automatic tests
(Only UI/layout changes, so no automatic tests added)
Manual tests
Done
Device: Motorola e13
OS: Android 13
Build tasks success
Successfully running following tasks on local:
./gradlew assembleDebug
./gradlew spotlessCheck