omh-storage integration #4455
Draft
omh-storage integration #4455
+5,166
−3,905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
One way another, it needs to happen anyway. Pending tasks before PR can leave draft status:
|
TranceLove
force-pushed
the
feature/omh-integration
branch
2 times, most recently
from
5ad9d38 to
00b918e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates omh-storage cloud storage functionality to replace cloudrail-si for cloud service support. The integration includes SDK-less implementations for Dropbox, Microsoft OneDrive, and Google Drive. The PR also updates the minimum Android version requirement to API level 26 (Android 8.0) and enables kotlinx coroutines usage throughout the codebase.
Key changes:
- Replaces cloudrail-si with omh-storage library for cloud storage integration
- Updates minimum SDK version from 21 to 26 (Android 8.0)
- Enables kotlin coroutines and updates kotlin version to 2.1.20
- Converts Java exceptions to Kotlin for better interoperability
Reviewed Changes
Copilot reviewed 150 out of 163 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates minSdk to 26, adds coroutines dependencies, removes cloudrail |
| app/src/main/java/com/amaze/filemanager/utils/omh/ | New OMH client helper classes for cloud integration |
| app/src/main/java/com/amaze/filemanager/filesystem/cloud/CloudUtil.kt | Rewrites CloudUtil from Java to Kotlin with omh-storage support |
| Multiple test files | Updates test SDK configurations from LOLLIPOP to O (API 26) |
| app/src/main/java/com/amaze/filemanager/utils/DataUtils.kt | Converts DataUtils from Java to Kotlin |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/src/test/java/com/amaze/filemanager/ui/notifications/NotificationConstantsTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+379
to
+464
| var gridfiles: ArrayList<String?>? | ||
| get() = gridfiles | ||
| set(gridfiles) { | ||
| if (gridfiles != null) { | ||
| for (gridfile in gridfiles) { | ||
| setPathAsGridOrList(gridfile, GRID) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This getter creates infinite recursion by calling itself. The getter should return the actual backing field or property, not call itself recursively.
TranceLove
force-pushed
the
feature/omh-integration
branch
2 times, most recently
from
ad08367 to
e5e1778
Compare
TranceLove
force-pushed
the
feature/omh-integration
branch
4 times, most recently
from
2919bfa to
07ed600
Compare
Collaborator
Author
|
TranceLove
force-pushed
the
feature/omh-integration
branch
4 times, most recently
from
6a2abd4 to
9f8c153
Compare
TranceLove
force-pushed
the
feature/omh-integration
branch
2 times, most recently
from
eb1ed76 to
a87506c
Compare
TranceLove
force-pushed
the
feature/omh-integration
branch
from
a87506c to
e8276eb
Compare
TranceLove
force-pushed
the
feature/omh-integration
branch
from
e8276eb to
ef6dba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration with https://github.com/openmobilehub/android-omh-auth and https://github.com/openmobilehub/android-omh-storage for Cloud storage integration.
However due the aged codebase of Amaze itself, there were some overhaul to the codebase itself in order to facilitate integration, with reduced code redundancy and unnecessary code.
Also
Open source compliance
Though omh libraries come as binary jar instead of Maven dependency, their source code are available for review and pending to merge into their mainline codebases. Once they are merged these jars can be replaced by Maven dependencies.
Issue tracker
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck