Skip to content

clarify how to show computation of inverse (MX2 checkit) #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

clarify how to show computation of inverse (MX2 checkit) #731

wants to merge 3 commits into from

Conversation

StevenClontz
Copy link
Contributor

No description provided.

@StevenClontz StevenClontz added linear-algebra checkit Involves randomized exercise banks labels Apr 25, 2025
@github-actions GitHub Actions
Copy link

🚀 Preview available 🚀

https://1d2fbf90.tbil.pages.dev

@StevenClontz StevenClontz marked this pull request as ready for review April 25, 2025 17:56
@jkostiuk
Copy link
Contributor

@StevenClontz was there more you were meaning to do here, or is this ready for review?

@StevenClontz
Copy link
Contributor Author

I think I already marked it ready for review. Taking a look back, I think I'm happy with the proposal.

@jkostiuk jkostiuk self-requested a review May 22, 2025 13:05
@jkostiuk
Copy link
Contributor

ah---i didn't realize that I could add myself as a reviewer. I thought one had to request a review from a specific person.

jkostiuk
jkostiuk requested changes May 22, 2025
View reviewed changes
Copy link
Contributor

@jkostiuk jkostiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@StevenClontz
Copy link
Contributor Author

StevenClontz commented May 22, 2025 •
edited
Loading

EDIT: ignore the below, I forgot which PR this was 😅

ah---i didn't realize that I could add myself as a reviewer. I thought one had to request a review from a specific person.

What I meant to say is that you can suggest changes without a review at all:

image

@github-actions GitHub Actions
Copy link

🚀 Preview available 🚀

https://d52e55c4.tbil.pages.dev

@StevenClontz StevenClontz requested a review from jkostiuk May 22, 2025 20:15
@jkostiuk
Copy link
Contributor

given we're making changes to MX2 in another PR, should I just leave this, or?

@StevenClontz
Copy link
Contributor Author

Oh right - either you can re-implement this there and I'll close this, or I'll incorporate this (if necessary) after #785 is merged.

@StevenClontz StevenClontz marked this pull request as draft May 22, 2025 20:50
@jkostiuk
Copy link
Contributor

sounds good. i'll get to work on my PR tomorrow or Monday---day got away from me today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkostiuk jkostiuk Awaiting requested review from jkostiuk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
checkit Involves randomized exercise banks linear-algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenClontz @jkostiuk