refactor MX1 to manually calculate one column, not whole product #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenClontz
changed the title
🚀 Preview available 🚀https://d07ed579.tbil.pages.dev
|
Contributor
Author
|
(despite the X, the checks are passing and I think this is ready for review) |
StevenClontz
commented
Nov 14, 2025
🚀 Preview available 🚀https://32b427a6.tbil.pages.dev
|
siwelwerd
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how we started asking for one column in MX2, I think we should ask for a random column of the product in MX1. Justification: it reinforces the meaning of the product as a standard matrix for a composition, rather than an arbitrary algorithm.