[fix] Splash 화면 낮은 API에서 실행시 발생하던 오류 수정(+ 탈퇴하기 버튼 위치 이동)#287
Merged
[fix] Splash 화면 낮은 API에서 실행시 발생하던 오류 수정(+ 탈퇴하기 버튼 위치 이동)#287
Conversation
jinuemong
reviewed
Mar 19, 2025
| import org.sopt.teamdateroad.presentation.ui.navigator.MainActivity | ||
| import org.sopt.teamdateroad.ui.theme.DATEROADTheme | ||
|
|
||
| class SplashActivity : ComponentActivity() { |
There was a problem hiding this comment.
이거 꼭 액티비티 써야하나요? navigation으로 해도 될 것 같은데
app/src/main/AndroidManifest.xml
Outdated
| </intent-filter> | ||
| </activity> | ||
|
|
||
| <!-- Main Activity --> |
Contributor
Author
There was a problem hiding this comment.
SingleActivity Architecture 유지되도록 수정했습니다!
https://youtu.be/eFZmMSm1G1c?si=4CbQB2DzPsBgDHq6
이 영상보면서 구현했던건데 지금으로서는 SingleActivitiy 유지 하는게 더 좋은 방법인 것 같네요.
인터넷 찾아보니까 Fragment로 하는 방법도 있고 하던데 추후에 더 찾아보고 더 좋은 방법 찾으면 적용해보겠습니다!
| } | ||
| Spacer(modifier = Modifier.weight(1f)) | ||
| DateRoadTextButton( | ||
| modifier = Modifier.align(Alignment.Start), |
| fun SplashScreen() { | ||
| fun SplashScreen(onTimeout: () -> Unit) { | ||
| LaunchedEffect(Unit) { | ||
| delay(2000) |
There was a problem hiding this comment.
companion object {
const val SPLASH_SCREEN_DELAY = 2000L
}
처럼 매직넘버 제거하면 좋을 것 가타요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢