Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multitouch & fullscreen for windows #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhscey
Copy link

@fhscey fhscey commented Jan 11, 2025

No description provided.

@Shua-github
Copy link

我很需要

@YuevUwU
Copy link
Contributor

YuevUwU commented Jan 18, 2025

I self-built it and I discovered that I can't use mouse-click if multi-touch is enabled.
Maybe the miniquad logic should to change to be compatible with both mouse and touch screen.

Built Repo:
(I'm not sure whether I can put binary here) https://github.com/YuevUwU/phira/tree/multi-touch

@fhscey
Copy link
Author

fhscey commented Jan 19, 2025

I self-built it and I discovered that I can't use mouse-click if multi-touch is enabled. Maybe the miniquad logic should to change to be compatible with both mouse and touch screen.

Built Repo: (I'm not sure whether I can put binary here) https://github.com/YuevUwU/phira/tree/multi-touch

Maybe hard. WM_TOUCH always notifies the window together with WM_MOUSE. To avoid repeated messages when touching the screen, one of them must be deprecated.

@YuevUwU
Copy link
Contributor

YuevUwU commented Jan 19, 2025

Maybe hard. WM_TOUCH always notifies the window together with WM_MOUSE. To avoid repeated messages when touching the screen, one of them must be deprecated.

An simple (maybe) idea is only apply WM_TOUCH detection for prpr::scene::game::GameScene
It may be not really general but it may work better because not everyone have a touchscreen.

Update on 01/22 01:15+0800:
[enhancement] disable multitouch during paused and enable when resumed

@fhscey
Copy link
Author

fhscey commented Jan 21, 2025

Maybe hard. WM_TOUCH always notifies the window together with WM_MOUSE. To avoid repeated messages when touching the screen, one of them must be deprecated.

An simple (maybe) idea is only apply WM_TOUCH detection for prpr::scene::game::GameScene
It may be not really general but it may work better because not everyone have a touchscreen.

Update on 01/22 01:15+0800:
[enhancement] disable multitouch during paused and enable when resumed

Why do this?

@YuevUwU
Copy link
Contributor

YuevUwU commented Jan 21, 2025

@fhscey
cuz I can't operate exit, restart, resume on multi-touch mode when I use Space to pause the gameplay.
So I have to let the game end.

Of course, no non-touchscreen should enable the multi-touch, so it will be categorized as [enhancement] for more operation methods.

I'm sorry I'm not an official nor a touch screen player but I made some comments.
And thank you, you did a great job.

@fhscey
Copy link
Author

fhscey commented Jan 22, 2025

@fhscey
cuz I can't operate exit, restart, resume on multi-touch mode when I use Space to pause the gameplay.
So I have to let the game end.

Of course, no non-touchscreen should enable the multi-touch, so it will be categorized as [enhancement] for more operation methods.

I'm sorry I'm not an official nor a touch screen player but I made some comments.
And thank you, you did a great job.

Ok I will consider adding this.

@fhscey fhscey force-pushed the main branch 2 times, most recently from f5e310b to 1c1b89f Compare January 22, 2025 04:56
@YuevUwU
Copy link
Contributor

YuevUwU commented Jan 22, 2025

I must have had a brain freeze to suggest such a method that lowers maintainability and usability...
Maybe one should try out WM_POINTER when one have some free time...

Note that there is still some changes needed with refer to YuevUwU@a988fe5

@ChickenPige0n ChickenPige0n added the enhancement New feature or request label Jan 30, 2025
@fhscey fhscey closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants