- 
                Notifications
    
You must be signed in to change notification settings  - Fork 101
 
Web Torch and Web String Blocks #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pelling/grammar in comments.
updateShape now checks ladders are facing the same way for support checks.
…that are not solid face, slabs, without solid faces... or the backs of other tin ladders.
…, when their supporting blocks are broken.
- coding standards - tin ladders supported by wooden ladders.
TODO: Breaks in water TODO: Acts as a source of light. TODO: Web String as a crafting ingredient.
TorchWeb is now a lightsource
This reverts commit 3642323
Also can break with water.
| 
           BTW: I supplied the textures I created to Jamiscus.  | 
    
| 
           Next time, please create a new branch from the latest version of TeamGalacticraft:main when you start work on a new feature to avoid cluttering up the PR (in this case, with tin ladder commits).  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if you could make all the models data generated since they are fairly simple.
        
          
                src/main/java/dev/galacticraft/mod/content/item/GCCreativeModeTabs.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/data/GCBlockLootTableProvider.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/data/model/GCModelProvider.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebStringBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebStringBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebStringBlock.java
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebTorchBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/data/recipes/GCDecorationRecipeProvider.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           Addressed all that.  | 
    
        
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebStringBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebStringBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebTorchBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/WebStringBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …bBlock entityInside behaviour to restrict the size of the block collision to just the web instead of a full block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have had another brief look and spotted a few more things, although they are more a matter of good style rather than any breaking issues.
        
          
                src/main/java/dev/galacticraft/mod/content/block/special/GCWebBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/data/model/GCModelProvider.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/resources/assets/galacticraft/models/block/web_string_bottom.json
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/GCWebBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dev/galacticraft/mod/content/block/special/GCWebBlock.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still doesn't seem to be a proper tool for breaking the web strings/torches quickly, but that shouldn't take too long to add in.
Also, it might be nicer to be able to climb web strings, albeit slowly. Perhaps they shouldn't slow entities down as much as vanilla cobwebs either, which are more substantial after all.
| 
           Also, spiders are able to pass through vanilla cobwebs without being slowed down, however this behaviour doesn't seem to have been inherited for the web strings/torches.  | 
    
Adds Web Torch and Web String blocks to the mod, including the following features: