Skip to content

Conversation

@reyjaz007
Copy link

  • Added a new entity, the cheese cow has a cheese crud loot table, interacting with a bucket will give you a cheese whiz bucke, texture is just a reskin of a basic cow
Cheese_cow_showcase.mp4
  • Added cheese whiz liquid, basic liquid with a new texture, missing some work
Cheese_whiz_showcase.mp4
  • Added a new cheese whel recepie. A new alternative recepie for a moon cheese whel, you will need a cheese whiz bucket and a compressor
Compressed_cheese_whel.mp4

To Do:

  • Liquid rework
  • Cheese cow naturaly spawn (moon spawn)
  • New textures?

The code for the cheese cow and a new liquid called cheese whiz, when compressed it makes a cheese wheel, still has un finish work on the liquid and spawning for the cow but I'm working on it
Put a space back
Copy link
Contributor

@Roelymole Roelymole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few inconsistencies (especially with spaces). In most of these cases you should hopefully be able to get a fairly good sense of the conventions by looking at similar parts of the codebase and emulating those.

EntityRendererRegistry.register(GCEntityTypes.PARACHEST, ParachestRenderer::new);
EntityRendererRegistry.register(GCEntityTypes.THROWABLE_METEOR_CHUNK, ThrownItemRenderer::new);
EntityRendererRegistry.register(GCEntityTypes.SKELETON_BOSS, EvolvedSkeletonBossRenderer::new);
EntityRendererRegistry.register(GCEntityTypes.CHEES_COW, CheeseCowEntityRender :: new);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an extra E in GCEntityTypes.CHEES_COW, also I would suggest renaming the CheeseCowEntityRender class to be more consistent with the other renderer classes.

Suggested change
EntityRendererRegistry.register(GCEntityTypes.CHEES_COW, CheeseCowEntityRender :: new);
EntityRendererRegistry.register(GCEntityTypes.CHEESE_COW, CheeseCowEntityRenderer::new);

private int processingTime = 1;
private long startTime;
@Environment(EnvType.CLIENT)
public class CheeseCowEntityRender extends MobRenderer <Cow, CowModel<Cow>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is conventional to not have a space between MobRenderer and the angle bracket of the type parameter.

@Override
public int getWidth() {
return 0;
public ResourceLocation getTextureLocation(Cow cheese_cow) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use camel case here, instead of snake case e.g. cheeseCow instead of cheese_cow.

Comment on lines +446 to +449
ShapelessCompressorRecipeBuilder.shapeless(GCItems.MOON_CHEESE_WHEEL)
.unlockedBy(getHasName(GCItems.CHEESE_WHIZ_BUCKET), has(GCItems.CHEESE_WHIZ_BUCKET))
.requires(GCItems.CHEESE_WHIZ_BUCKET)
.save(output);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably suggest putting this after the cracker compressing recipe, if anything, since they are both foods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a single texture inside a subfolder seems a bit superfluous. I would suggest just moving it up a level to src/main/resources/assets/galacticraft/textures/entity/cheese_cow.png.

Comment on lines +197 to +198
ParticleFactoryRegistry.getInstance().register(GCParticleTypes.DRIPPING_CHEESE_WHIZ, DrippingCheeseWhizProvider:: new);
ParticleFactoryRegistry.getInstance().register(GCParticleTypes.FALLING_CHEESE_WHIZ, FallingCheeseWhizProvider:: new);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing is a bit inconsistent with a space after the double colon ::

this.advancement(Advancements.EAT_MOON_CHEESE_CURD, "Wensleydale? Stilton?", "Eat Moon Cheese Curd");
this.advancement(Advancements.CHEESE_AND_CRACKERS, "It's Like No Cheese I've Ever Tasted...", "Eat cheese and crackers");
this.advancement(Advancements.CHEESE_TAX, "Cheese Tax", "Give Cheese to a pet Wolf");
this.advancement(Advancements.CHEESE_WHIZ, "Is this cheese?", "Milk a cheese cow");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like "Hey Diddle Diddle" might make a good advancement title for something to do with a cow that is found on the Moon, although not necessarily milking one.
https://en.wikipedia.org/wiki/Hey_Diddle_Diddle

Also, the capitalization style (for English translations at least) would be to capitalize the first letter of cheese and cow to give "Milk a Cheese Cow", since "Cheese Cow" is the name of an entity.

public static final Item OLI_GRUB_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.OLI_GRUB, new SpawnEggItem(GCEntityTypes.OLI_GRUB, 0xd4dd7e, 0xa4bf63, new Item.Properties()));
public static final Item GREY_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.GREY, new SpawnEggItem(GCEntityTypes.GREY, 0x656463, 0x769e41, new Item.Properties()));
public static final Item ARCH_GREY_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.ARCH_GREY, new SpawnEggItem(GCEntityTypes.ARCH_GREY, 0x656463, 0x2d8563, new Item.Properties()));
public static final Item CHEESE_COW_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.CHEESE_COW, new SpawnEggItem(GCEntityTypes.CHEES_COW, 0xffa500,0Xcc8400, new Item.Properties()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space after the comma between the two color codes.

public static final Item CRUDE_OIL_BUCKET = ITEMS.register(Constant.Item.CRUDE_OIL_BUCKET, new BucketItem(GCFluids.CRUDE_OIL, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1)));
public static final Item FUEL_BUCKET = ITEMS.register(Constant.Item.FUEL_BUCKET, new BucketItem(GCFluids.FUEL, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1)));
public static final Item SULFURIC_ACID_BUCKET = ITEMS.register(Constant.Item.SULFURIC_ACID_BUCKET, new BucketItem(GCFluids.SULFURIC_ACID, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1)));
public static final Item CHEESE_WHIZ_BUCKET = ITEMS.register(Constant.Item.CHEESE_WHIZ_BUCKET, new BucketItem(GCFluids.CHEESE_WHIZ, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1)) );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be a space before the last closing bracket.

import net.minecraft.world.level.material.Fluid;

public abstract class CheeseWhizFluid extends BasicFluid{
protected CheeseWhizFluid(){super (true, true,0, 5,30,100.0F);}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is all over the place...

Suggested change
protected CheeseWhizFluid(){super (true, true,0, 5,30,100.0F);}
protected CheeseWhizFluid() {
super(true, true, 0, 5, 30, 100.0F);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants