- 
                Notifications
    
You must be signed in to change notification settings  - Fork 101
 
Feat: Cheese cow! #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: Cheese cow! #523
Conversation
The code for the cheese cow and a new liquid called cheese whiz, when compressed it makes a cheese wheel, still has un finish work on the liquid and spawning for the cow but I'm working on it
Put a space back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few inconsistencies (especially with spaces). In most of these cases you should hopefully be able to get a fairly good sense of the conventions by looking at similar parts of the codebase and emulating those.
| EntityRendererRegistry.register(GCEntityTypes.PARACHEST, ParachestRenderer::new); | ||
| EntityRendererRegistry.register(GCEntityTypes.THROWABLE_METEOR_CHUNK, ThrownItemRenderer::new); | ||
| EntityRendererRegistry.register(GCEntityTypes.SKELETON_BOSS, EvolvedSkeletonBossRenderer::new); | ||
| EntityRendererRegistry.register(GCEntityTypes.CHEES_COW, CheeseCowEntityRender :: new); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an extra E in GCEntityTypes.CHEES_COW, also I would suggest renaming the CheeseCowEntityRender class to be more consistent with the other renderer classes.
| EntityRendererRegistry.register(GCEntityTypes.CHEES_COW, CheeseCowEntityRender :: new); | |
| EntityRendererRegistry.register(GCEntityTypes.CHEESE_COW, CheeseCowEntityRenderer::new); | 
| private int processingTime = 1; | ||
| private long startTime; | ||
| @Environment(EnvType.CLIENT) | ||
| public class CheeseCowEntityRender extends MobRenderer <Cow, CowModel<Cow>> { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is conventional to not have a space between MobRenderer and the angle bracket of the type parameter.
| @Override | ||
| public int getWidth() { | ||
| return 0; | ||
| public ResourceLocation getTextureLocation(Cow cheese_cow) { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use camel case here, instead of snake case e.g. cheeseCow instead of cheese_cow.
| ShapelessCompressorRecipeBuilder.shapeless(GCItems.MOON_CHEESE_WHEEL) | ||
| .unlockedBy(getHasName(GCItems.CHEESE_WHIZ_BUCKET), has(GCItems.CHEESE_WHIZ_BUCKET)) | ||
| .requires(GCItems.CHEESE_WHIZ_BUCKET) | ||
| .save(output); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably suggest putting this after the cracker compressing recipe, if anything, since they are both foods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a single texture inside a subfolder seems a bit superfluous. I would suggest just moving it up a level to src/main/resources/assets/galacticraft/textures/entity/cheese_cow.png.
| ParticleFactoryRegistry.getInstance().register(GCParticleTypes.DRIPPING_CHEESE_WHIZ, DrippingCheeseWhizProvider:: new); | ||
| ParticleFactoryRegistry.getInstance().register(GCParticleTypes.FALLING_CHEESE_WHIZ, FallingCheeseWhizProvider:: new); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing is a bit inconsistent with a space after the double colon ::
| this.advancement(Advancements.EAT_MOON_CHEESE_CURD, "Wensleydale? Stilton?", "Eat Moon Cheese Curd"); | ||
| this.advancement(Advancements.CHEESE_AND_CRACKERS, "It's Like No Cheese I've Ever Tasted...", "Eat cheese and crackers"); | ||
| this.advancement(Advancements.CHEESE_TAX, "Cheese Tax", "Give Cheese to a pet Wolf"); | ||
| this.advancement(Advancements.CHEESE_WHIZ, "Is this cheese?", "Milk a cheese cow"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something like "Hey Diddle Diddle" might make a good advancement title for something to do with a cow that is found on the Moon, although not necessarily milking one.
https://en.wikipedia.org/wiki/Hey_Diddle_Diddle
Also, the capitalization style (for English translations at least) would be to capitalize the first letter of cheese and cow to give "Milk a Cheese Cow", since "Cheese Cow" is the name of an entity.
| public static final Item OLI_GRUB_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.OLI_GRUB, new SpawnEggItem(GCEntityTypes.OLI_GRUB, 0xd4dd7e, 0xa4bf63, new Item.Properties())); | ||
| public static final Item GREY_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.GREY, new SpawnEggItem(GCEntityTypes.GREY, 0x656463, 0x769e41, new Item.Properties())); | ||
| public static final Item ARCH_GREY_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.ARCH_GREY, new SpawnEggItem(GCEntityTypes.ARCH_GREY, 0x656463, 0x2d8563, new Item.Properties())); | ||
| public static final Item CHEESE_COW_SPAWN_EGG = ITEMS.register(Constant.SpawnEgg.CHEESE_COW, new SpawnEggItem(GCEntityTypes.CHEES_COW, 0xffa500,0Xcc8400, new Item.Properties())); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a space after the comma between the two color codes.
| public static final Item CRUDE_OIL_BUCKET = ITEMS.register(Constant.Item.CRUDE_OIL_BUCKET, new BucketItem(GCFluids.CRUDE_OIL, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1))); | ||
| public static final Item FUEL_BUCKET = ITEMS.register(Constant.Item.FUEL_BUCKET, new BucketItem(GCFluids.FUEL, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1))); | ||
| public static final Item SULFURIC_ACID_BUCKET = ITEMS.register(Constant.Item.SULFURIC_ACID_BUCKET, new BucketItem(GCFluids.SULFURIC_ACID, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1))); | ||
| public static final Item CHEESE_WHIZ_BUCKET = ITEMS.register(Constant.Item.CHEESE_WHIZ_BUCKET, new BucketItem(GCFluids.CHEESE_WHIZ, new Item.Properties().craftRemainder(Items.BUCKET).stacksTo(1)) ); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be a space before the last closing bracket.
| import net.minecraft.world.level.material.Fluid; | ||
| 
               | 
          ||
| public abstract class CheeseWhizFluid extends BasicFluid{ | ||
| protected CheeseWhizFluid(){super (true, true,0, 5,30,100.0F);} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is all over the place...
| protected CheeseWhizFluid(){super (true, true,0, 5,30,100.0F);} | |
| protected CheeseWhizFluid() { | |
| super(true, true, 0, 5, 30, 100.0F); | |
| } | 
Cheese_cow_showcase.mp4
Cheese_whiz_showcase.mp4
Compressed_cheese_whel.mp4
To Do: