feat: allow hoppers, droppers and crafters to interact with Galacticraft machines #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms matching the filter into transfer item slots and removing non-matching items
marcus8448
requested changes
Jan 28, 2025
There was a problem hiding this comment.
I'd prefer a new transfer type instead of changing the functionality of TRANSFER (maybe PROCESSING? Feel free to come up with a better name).
I can see the functionality being helpful for machines like the oxygen (de)compressor, but TRANSFER was expressly made to be untouched by external I/O. (It would be annoying if you put a battery into a circuit fabricator and then it clogged the wafer output.)
src/main/java/dev/galacticraft/machinelib/impl/compat/transfer/ExposedSlotImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/galacticraft/machinelib/impl/storage/MachineItemStorageImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoppers, droppers and crafters can be used to insert items into TransferType.INPUT, TransferType.STORAGE and TransferType.PROCESSING slots of machines provided they match the filter.
Hoppers can be used to remove items from TransferType.OUTPUT and TransferType.STORAGE slots.
Hoppers can be used to remove items from TransferType.PROCESSING slots provided that they NO LONGER match the filter.
Note that the corresponding side of the machine needs to be configured to allow items in/out/both.
This does not work with dispensers quite yet for some reason.Dispensers do not insert items into vanilla containers either.Simple examples include automatically supplying a coal generator with coal or creating an automatic smelter using an electric furnace etc.
Examples of the behavior of TransferType.PROCESSING slots include inserting empty oxygen tanks into the oxygen compressor and only when they are full do they no longer match the canInsertFluid filter and may be removed using a hopper. Other examples include filling/emptying buckets or charging/discharging batteries and removing them with a hopper when the buckets/batteries are full/empty.