Complete the debug screen migration to Compose #12803
Open
+243
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HatakeKakashri
requested review from
Isira-Seneviratne,
Stypox and
theimpulson
- Added all the preference items of Debug screen. - Implemented all actions / callbacks for the debug preferences, including checking for new streams, intentionally crashing the app, and displaying error notifications and snackbars. - Refactored the `SettingsViewModel` to use a `BooleanPreference` helper class to reuse and reducing boilerplate for state management. - Created a shared `TextBase` composable to remove duplicated UI logic between `SwitchPreference` and `TextPreference`. - Move the build-variant-dependent logic for LeakCanary and reused it in Compose and Fragment, this logic is used for ensuring the leak canary fields are only enabled in debug variants. - Fixed a layout bug in `SwitchPreference` where long summary text could misalign the switch component and also adjusted the paddings for consistency.
HatakeKakashri
force-pushed
the
debug_screen_migration
branch
from
03d392b to
fce5ec6
Compare
theimpulson
reviewed
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
SettingsViewModelto use aBooleanPreferencehelper class to reuse and reducing boilerplate for state management.TextBasecomposable to remove duplicated UI logic betweenSwitchPreferenceandTextPreference.SwitchPreferencewhere long summary text could misalign the switch component and also adjusted the paddings for consistency.Before/After Screenshots/Screen Record (The toolbar colors are to be handled in a seperate PR #12654)
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence