Fix removing unwatched streams from playlist when using "remove watched" #12929
+130
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
6 tasks
The bug is caused by a wanted but forgotten inconsistency in the database. A stream can be listed in the watch history (StreamHistoryEntity) while having no corresponding playback state (StreamStateEntity) containing the matching playback position. This is caused by the fact that NewPipe does not consider a watch time of less than five seconds to be worthy to be put into the StreamStateEntity because the video was most likely played by error. Those videos are, however, counted and stored in the watch history.
TobiGr
force-pushed
the
fix/playlist-remove-watched
branch
2 times, most recently
from
d14d330 to
655666c
Compare
Playlists can also contain audio-only items. Therefore, the term "stream" is used.
TobiGr
force-pushed
the
fix/playlist-remove-watched
branch
from
655666c to
6cefb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Bug fix
The bug is caused by a wanted but forgotten inconsistency in the database. A stream can be listed in the watch history (StreamHistoryEntity) while having no corresponding playback state (StreamStateEntity) containing the matching playback position. This is caused by the fact that NewPipe does not consider a watch time of less than five seconds to be worthy to be put into the StreamStateEntity because the video was most likely played by error. Those videos are, however, counted and stored in the watch history.
I think we need to discuss whether we should add the stream to the watch history at all.
UI/UX improvements
The dialog with three options was changed to a yes and cancel button and a checkbox. The strings were changed to respect that a playlist can also contain audio streams. "streams" is now used in favour of "video".
Before/After Screenshots/Screen Record
A screen record with the old version is in #12917. The following recording shows the new behaviour and dialog.
Screen_recording_20251221_212542.webm
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
This backup can be used to easily test different scenarios: NewPipe-Data-Playlist-stream-states.zip
The test playlist contains five streams:
Due diligence