Convert part of Tab logic to kotlin #12939
Open
+611
−747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theimpulson
reviewed
Dec 25, 2025
| import org.schabi.newpipe.util.ServiceHelper | ||
| import java.util.Objects | ||
|
|
||
| abstract class Tab { |
Member
There was a problem hiding this comment.
It might be better to make it a data class and stop overriding hashcode and equals methods
Author
There was a problem hiding this comment.
Do you mean to make Tab a data class? It would mean I can't make it abstract. I am almost sure it is possible to make inner classes to be data classes but not top class.
I also though about it and about composition but the more I edit the less I am sure code still is doing the same...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Here I converted settings/tabs/Tab.kt from java to kotlin
Tbh I am not even fully sure if it works (I tested but
¯\_(ツ)_/¯). And pr as a whole a bit messy because I know kotlin very bad and for example some fields are declared as nullable to just be 100% set to not null. Thanks to the fact it is a kotlin some things become cleaner but as I said some become less cleaner. So why am I sending this PR? I can't do better for now so sorry for sending this crap... Maybe doesn't look at it!APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence