[Feature] Add IPv4-only network option (#13332) - #13632
Conversation
|
Is this intentionally designed such that if the system DNS only returns IPv6 address(es), that they will be used even if IPv4 Only is enabled? Or is that an oversight? |
|
Please note: the contribution guidelines currently say at the top that currently we are only focusing on bugfixes and refactors right now. That being said, this feature steers closer to bugfix than feature as it strives to bypass YT anti-bot checks. But for future reference: as per the guidelines, you must state your intent to open a PR for issues before opening a PR
For these reasons, please do not be surprised if this is not reviewed any time soon, and do not be surprised if it gets closed as we were not given opportunity to vet your implementation approach before you started working on it, so your solution may not be viable. |
You're right that was an oversight, not intentional. Fixed it in fb6dfe8 and 4a0906d, it now throws an UnknownHostException if no IPv4 address is found instead of falling back to IPv6. |
About contributing, I should have mentioned this on the issue first before starting. I couldn't comment or assign myself without prior contributions to the repo, so should've reached out on Matrix or e-mail instead. Happy to keep working on it if there's interest, but I get it if it doesn't get reviewed right away or ends up closed. |
What is it?
Description of the changes in your PR
Added a network settings toggle to allow users to disable IPv6 and use only IPv4 for network requests. This solves issues where:
Implementation:
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence