Migrate 'Video & Audio' settings screen to compose multiplatform - #13714
Open
Idadelveloper wants to merge 18 commits into
Open
Migrate 'Video & Audio' settings screen to compose multiplatform#13714Idadelveloper wants to merge 18 commits into
Idadelveloper wants to merge 18 commits into
Conversation
|
Contributor
Author
|
@theimpulson this looks huge because #13684 is still in review and i branched out of the branch with the changes for the appearance settings screen. Once the review of that is done the changes shown here should be less. Also there are some missing parts of this screen to avoid the pr being too large and will finalize in a subsequent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is it?
Description of the changes in your PR
PreferenceCategoryTitlereusable composable for section headers inside settings screensVideoAudioSettingsViewModelVideoAudioPreferencesso the screen and the view mode reference the same constantsVideoAudioSettingsFragment: "Show higher resolutions" inserts 2160p/1440p and resets high selections when disabledVideoAudioSettingsScreenTestNot in this PR (follow-ups):
AppearanceActionsBefore/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence