Skip to content

Migrate 'Video & Audio' settings screen to compose multiplatform - #13714

Open
Idadelveloper wants to merge 18 commits into
TeamNewPipe:devfrom
Idadelveloper:video-audio
Open

Migrate 'Video & Audio' settings screen to compose multiplatform#13714
Idadelveloper wants to merge 18 commits into
TeamNewPipe:devfrom
Idadelveloper:video-audio

Conversation

@Idadelveloper

Copy link
Copy Markdown
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Introduces PreferenceCategoryTitle reusable composable for section headers inside settings screens
  • Adds VideoAudioSettingsViewModel
  • Centralizes video/audio preference keys, values, and defaults in VideoAudioPreferences so the screen and the view mode reference the same constants
  • Adds VideoAudioSettingsScreen
  • Ports the dynamic behavior from VideoAudioSettingsFragment: "Show higher resolutions" inserts 2160p/1440p and resets high selections when disabled
  • Wires the "Video and audio" row on the settings home screen to the new destination
  • Adds screen tests: VideoAudioSettingsScreenTest
Not in this PR (follow-ups):
  • ExoPlayer settings sub-screen
  • Overlay-permission snackbar when "Minimize on app switch" is set to popup without draw-over-apps permission (needs a platform actions interface like AppearanceActions

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/giant PRs with more than 750 changed lines label Jul 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Idadelveloper

Copy link
Copy Markdown
Contributor Author

@theimpulson this looks huge because #13684 is still in review and i branched out of the branch with the changes for the appearance settings screen. Once the review of that is done the changes shown here should be less. Also there are some missing parts of this screen to avoid the pr being too large and will finalize in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/giant PRs with more than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant