Fix playlist not clearing when navigating back (#8888) - #13732
Fix playlist not clearing when navigating back (#8888)#13732Elitenotavailable wants to merge 1 commit into
Conversation
|
|
I am new so how long does it usually takes to review a pull request ? |
|
@Elitenotavailable This depends on how complicated the PR is and if there is enough free time to work on NewPipe. Was this PR submitted as part of a university or high scholl course? There is a similar PR that is migrating the playlist to view model. @Isira-Seneviratne Can you take a look at your PR and this one? Our plan is to stop working on the refactor branch and merge directly to dev (see #13635). I think that you introduced a separate library for paging. |
|
@TobiGr Actually Yes , This can be said as a part of university project , I need to contribute to big open source projects like more than a 100 stars to apply for the open source development community of my college next week and I am also Learning :) , this is my first PR |



What is it?
Description of the changes in your PR
LocalPlaylistFragmentto a newLocalPlaylistViewModel(Kotlin).viewModelScopeto ensure that database mutations survive fragment destruction when a user navigates back quickly after confirmation.LocalPlaylistFragmentto observe the ViewModel'sworkStatefor managing the loading spinner and error reporting.onDestroyView, prematurely cancelling pending database writes.Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence